Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Don't check for Same-Site cookie on Chrome Android #1456

Closed
wants to merge 1 commit into from
Closed

[stable10] Don't check for Same-Site cookie on Chrome Android #1456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,14 @@ private static function performSameSiteCookieProtection() {
return;
}

// Chrome on Android has a bug that it doesn't sent cookies with the
// same-site attribute for the download manager. To work around that
// all same-site cookies get deleted and recreated directly. Awesome!
// FIXME: Remove once Chrome 54 is deployed to end-users
// @see https://github.com/nextcloud/server/pull/1454
if($request->isUserAgent([\OC\AppFramework\Http\Request::USER_AGENT_ANDROID_MOBILE_CHROME])) {
return;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I also should move the logic from "self::sendSameSiteCookies();" above this so it catches some more cases. Will correct later.

}

if(count($_COOKIE) > 0) {
$requestUri = $request->getScriptName();
Expand Down