Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve update channel layout to be a popup menu #14168

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Improve update channel layout to be a popup menu #14168

merged 2 commits into from
Feb 14, 2019

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Feb 12, 2019 •
edited
Loading

This is how it looks (normal menu, after and update, with a non-default entry).

bildschirmfoto 2019-02-13 um 15 23 51

bildschirmfoto 2019-02-12 um 18 09 20

bildschirmfoto 2019-02-13 um 14 35 25

@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Feb 12, 2019
@MorrisJobke MorrisJobke force-pushed the feature/noid/improve-update-channel-layout branch 2 times, most recently from c49623f to 8d5cda6 Compare February 12, 2019 17:18
@MorrisJobke MorrisJobke mentioned this pull request Feb 12, 2019
Closed
@ChristophWurst
Copy link
Member 

* use better icons @nextcloud/designers ideas welcome
  • 🐘 production
  • 🐴 stable
  • 🐯 beta
  • 🤡 git

@jancborchardt

This comment has been minimized.

Sign in to view
@MorrisJobke

This comment has been minimized.

Sign in to view
skjnldsv
skjnldsv previously requested changes Feb 13, 2019
View reviewed changes
@nickvergessen

This comment has been minimized.

Sign in to view
@MorrisJobke

This comment has been minimized.

Sign in to view
@MorrisJobke MorrisJobke force-pushed the feature/noid/improve-update-channel-layout branch from ba198e1 to 36a18b9 Compare February 13, 2019 14:03
skjnldsv
skjnldsv previously requested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks/comments :)

@MorrisJobke MorrisJobke force-pushed the feature/noid/improve-update-channel-layout branch 2 times, most recently from d4b868a to aa2135d Compare February 13, 2019 14:22
@MorrisJobke
Improve update channel layout to be a popup menu
90bcc8e 
* now the entries are in a popup menu
* if a non-default channel is used the entry will be at the bottom
* channel descriptions are embeded into the menu
* use nextcloud-vue componenets for the channel selector
* update nextcloud-vue dependency from 0.6.1 to 0.6.3
* fixes #13806

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Fix corners that are cut in popup menu in Safari
15ae633 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the feature/noid/improve-update-channel-layout branch from aa2135d to 15ae633 Compare February 13, 2019 14:30
@MorrisJobke MorrisJobke dismissed skjnldsv’s stale review February 13, 2019 14:30

Fixed all comments

@MorrisJobke
Copy link
Member Author

I fixed the comments by @skjnldsv and this is now fully rebased and squashed.

I also adjusted the text for production to be this:

Will always provide the latest patch level, but not update to the next major release immediately. That update usually happens with the second minor release (x.0.2) and only if the instance is already on the latest minor version.

Does this make sense? It should reflect the planned changes from #8799 that is then done to the updater_server.

@MorrisJobke MorrisJobke mentioned this pull request Feb 13, 2019
Closed
skjnldsv
skjnldsv approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!! :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 14, 2019
@MorrisJobke MorrisJobke merged commit 9d1d4d6 into master Feb 14, 2019
@MorrisJobke MorrisJobke deleted the feature/noid/improve-update-channel-layout branch February 14, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement feature: install and update
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.

Improved update channels design in settings
5 participants
@MorrisJobke @ChristophWurst @jancborchardt @nickvergessen @skjnldsv