Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable15] always use multipart uploader for s3 uploads #13882

Merged
merged 1 commit into from
Jan 29, 2019
Merged

[stable15] always use multipart uploader for s3 uploads #13882

merged 1 commit into from
Jan 29, 2019

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #13866

@icewind1991
always use multipart uploader for s3 uploads
ff5f28a 
the multipart uploader handles non seekable streams while `upload` does not

Signed-off-by: Robin Appelman <robin@icewind.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 15.0.3 milestone Jan 29, 2019
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 29, 2019
Merged
MorrisJobke
MorrisJobke approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Jan 29, 2019
@rullzer rullzer mentioned this pull request Jan 29, 2019
Closed
@rullzer rullzer merged commit 95f4c21 into stable15 Jan 29, 2019
@rullzer rullzer deleted the backport/13866/stable15 branch January 29, 2019 14:17
@MorrisJobke MorrisJobke mentioned this pull request Jan 30, 2019
Merged
@maprambo maprambo mentioned this pull request Feb 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: filesystem
Projects
None yet
Milestone
Nextcloud 15.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @MorrisJobke @icewind1991