Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show label if the shareWith value is relevant #12334

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Only show label if the shareWith value is relevant #12334

merged 1 commit into from
Nov 7, 2018

Conversation

juliusknorr
Copy link
Member

For local users / groups the display name is enough to show, we just need details for email/remote shares

Before:
image

After:
image

Fixes #12164

@juliusknorr
Only show label if the shareWith value is relevant
8ed945a 
For local users / groups the display name is enough to show, we just need details for email/remote shares

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added this to the Nextcloud 15 milestone Nov 7, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 7, 2018
Merged
29 tasks
blizzz
blizzz approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good and works as expected, thx!

ChristophWurst
ChristophWurst approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

MorrisJobke
MorrisJobke approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works and looks nice 👍

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 7, 2018
@MorrisJobke MorrisJobke merged commit 35a9c51 into master Nov 7, 2018
@MorrisJobke MorrisJobke deleted the bugfix/12164/share-dialog-userid branch November 7, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusknorr @MorrisJobke @ChristophWurst @blizzz