-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/change password changes #1229
Conversation
@raghunayyar, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @MTGap and @Henni to be potential reviewers |
I see there is an issue with the tipsy positioning in my last commit, fixing that. |
9abd950
to
f5faf14
Compare
Fixed, up for review now. :) |
|
@MorrisJobke done ;) |
@nextcloud/designers need a couple of thumbs up here. ;) |
|
@raghunayyar sorry for those new issues :( |
Beside the two points it works very well. |
I think this one could be done in an additional ticket. |
512a049
to
6b2680f
Compare
@MorrisJobke I still can't reproduce the bug you are talking about and you showed me in the conference on my machine. Can you take this up if you got some extra time? |
Is this the only thing left? Then change the label to "3 - To review" and I will give this another try ;) |
All yours @MorrisJobke |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
I removed the old "Saving ..." and "Successfully saved" messages, because they only duplicate the feedback. Beside that it works nicely 👍 |
@rullzer @nickvergessen Please review |
I will fix the issue with the password policy app in a separate PR |
|
thanks @MorrisJobke, much appreciated. :D |
Also, should this be backported? @karlitschek |
nice. please backport 👍 |
I would not backport this one here. It's mostly cosmetic stuff and it works in stable versions. |
Is this okay with you, @raghunayyar? @nickvergessen @LukasReschke Opinions? |
It’s polishing and non-critical, so I wouldn’t backport it really. |
Fixes all issues stated in
#1061
Please review @nextcloud/designers @jancborchardt