-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put back headings to regular #11616
Put back headings to regular #11616
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
I actually prefer that the file name stood out a bit more clearly. 🙈 |
I feel like it's already pretty obvious here: https://user-images.githubusercontent.com/14975046/46483306-9d04ff00-c7f7-11e8-883b-eb172c80ab23.png ? |
/me gets 🍿 |
Light (300) and Regular (400) is not a proper font weight pairing – too little difference amd contrast. 👎 Our pairing is Light (300, for body text) & Semibold (600, for highlight/heading), nothing else. Regular is only there in the first place because light doesn't work on some displays. Mixing in regular for headings would make us use 3 font-weights and that's nonsense. For readability, I was actually considering moving to Regular (400, for body) + Bold (700, for highlight) but that might be too much. (There's a branch if you want to check that out. ;) Sorry but typography is pretty core to the experience so we should not choose it on a whim. Headings are Semibold and ever since the change, everything is so much more organized and clear. |
The difference between the two is too rough, It really looks like a bad design people did on old websites.
Which is exactly why I'm arguing here, if I did not find this important I would have leave it like that. Don't call my suggestion a whim because I disagree with you please. |
I can't make an educated decision on this issue. I suspect that it makes a bigger difference how these fonts are displayed on each one's screen (conditioned by browser, OS, antialiasing level, screen type (LED, OLED...), screen quality, screen size...) that we won't be able to select the one that looks better in general. It's quite possible that 400 looks better on @skjnldsv 's screen while 600 looks better on @jancborchardt 's 😃 Maybe you could try this out on several different configurations? And please don't share screenshots taken on Google The Font Ripper 🗡️ ...ehh, I mean Google Chrome 😆 |
Why is that? :) @jancborchardt another example on the contacts app: |
Just search "google chrome font rendering" 😉 |
But this was related to the chrome <37 and windows, back in 2014, right? |
@skjnldsv bad example with the Contacts app – it suffers from the same issue as the personal settings of course – too many headers on one page. In that case it should be h3 with font-weight: 300 (not 400), just like we fixed it on the personal settings.
This comparison isn't really working or not true. It's not on old websites, check e.g. apple.com, slack.com and others. Hey, even the Steve Schoger dude people love so much wrote it in the very tip you pasted in the original pull request. Good information architecture needs contrast and clear focus. The difference between 300 and 400 is not enough to convey that. And especially as we already use 600 for buttons and headings in the left navigation (yes, we already use bold for headings) it is fitting for h2, h3, h4 etc. |
Btw, we tested on @MorrisJobke's Macbook and @ChristophWurst's laptop top, looked markedly better there too. A good test is to squint: If you can't make out the structure, or the difference of heading and body text then, the typography failed. |
EDIT: ah nope, I was wrong! I refreshed and it is indeed 300.
But we're using light, so the diff is between 100 and 400, which is the same as regular to semibold (300 to 600) EDIT2:
There is something to change here, 600 and every title is not coherent I think :) |
If you need to manually override a global css rule, this is either:
|
good argument @skjnldsv - headings (with predefiend styling) should make sense in all cases globally. |
So your proposal is to use h3 for Personal settings and use font-weight: 300 for h3? The problem is that this would create readability issues wherever else h3 is used, especially in vertical writing. Like in the 2FA settings (cc @ChristophWurst who initially brought this exact problem up) and in the News app too. I really think that the Personal settings page with the large amount of heading + box is a very special case, and it’s fine to simply reduce the font-weight there.
This is not correct. Light is 300, not 100. This is the naming table, to clear it up:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would still close this, see my comment at #11616 (comment)
@jancborchardt Ah yes, thanks for the details! 👍
|
But we are not discussing about CSS, but about design. There are exceptions sometimes. Remember when people were confused/critical when they found out that the G of the Google logo is not a perfect circle: https://www.creativebloq.com/news/google-logo-sparks-correct-design-debate Design is not only dogmatic following of standards. As said:
Same for Contacts. Those two are the exceptions for headings being set in regular since there are a lot of headings and fields. But the default for headings is the current one (Semibold, maybe soon Bold). |
I'll provide a standard next week :) |
Sorry @jancborchardt but this is looking far too agressive with 600 😕
I did not realised it was that much on the previous pr 🙈
Regular is better imho, what do you think? @nextcloud/designers
If you consider that our default is set on light, regular = semibold and semibold = bold for us ;)