Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set headings to Semibold for better information architecture #11538

Merged
merged 4 commits into from
Oct 3, 2018

Conversation

jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Oct 2, 2018

See for yourself @nextcloud/designers – much better to distinguish and see what is in focus:

Before & after in files:
screenshot from 2018-10-02 11-37-51
screenshot from 2018-10-02 11-37-03

Before and after in admin settings:
screenshot from 2018-10-02 12-03-04
screenshot from 2018-10-02 12-01-12

…architecture

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels Oct 2, 2018
@jancborchardt jancborchardt added this to the Nextcloud 15 milestone Oct 2, 2018
@jancborchardt
Copy link
Member Author

Also cc @karlitschek @jospoortvliet – it's something we should also consider for the website and other materials.

@skjnldsv
Copy link
Member

skjnldsv commented Oct 2, 2018

I have to disagree about the headings on the personal settings :) They feel out of place. 😕
It looks like you've changed the font family. Maybe try regular? Or something like that?
It looks like we've gone too far here.

I agree with the concept, but this looks worst than before 😉
dkgk-ibueae58ll

@jancborchardt
Copy link
Member Author

jancborchardt commented Oct 2, 2018

@skjnldsv maybe you'd prefer if in the settings it stays h2? Just cherry-pick only the first commit.

And no, the fon-family isn't changed as you can see from the code. It's simply semibild, what we use for highlights and buttons already.

@MorrisJobke
Copy link
Member

EDIT: precision: I'm talking about the headings on the personal settings :)

We also noticed that and were thinking about making it not a heading there but normal text. But all the other settings look far better

@skjnldsv
Copy link
Member

skjnldsv commented Oct 2, 2018

@skjnldsv maybe you'd prefer if in the settings it stays h2? Just cherry-pick only the first commit.

And no, the fon-family isn't changed as you can see from the code. It's simply semibild, what we use for highlights and buttons already.

No, actually I think I prefere without the bold, only going back to the original weight.
BUT without the lightness, so font-weight: 300 (inherit)
capture d ecran_2018-10-02_12-27-25

What do you think? It doesn't draw that much attention, but is still perfectly readable (far better than the previous light) 😁

@pixelipo
Copy link
Contributor

pixelipo commented Oct 2, 2018

Or perhaps try with bold, but leave opacity at .57?

I agree about the visibility - something definitely needs to be done here, but bold&black stands out too much. We seem to lose this light, airy feeling that NC interface has.

@jancborchardt - I think you tagged screenshots incorrectly -> personal are described as admin and vice versa.

@MorrisJobke - related to ⬆️ which headings are you referring to?

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member Author

No, actually I think I prefere without the bold, only going back to the original weight.
BUT without the lightness, so font-weight: 300 (inherit)

@skjnldsv done, check it out! :) And yes, it did look off with the bolding there, just because there are soo many headings on the personal page. So it’s a good exception.

Or perhaps try with bold, but leave opacity at .57?

@pixelipo that looked quite out of place. Just leaving the font-weight at 300 (Light) is good. What do you think?

I agree about the visibility - something definitely needs to be done here, but bold&black stands out too much. We seem to lose this light, airy feeling that NC interface has.

Yeah – remember though it’s Semibold, so not that much anyway. And it can also be light and airy even with Regular & Bold as you can see from Apple for example. After all, if stuff is not readable it doesn’t matter which feel it has. ;)

I think you tagged screenshots incorrectly -> personal are described as admin and vice versa.

@pixelipo thanks, fixed it. :)

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssssss

@rullzer
Copy link
Member

rullzer commented Oct 2, 2018

👍

@MorrisJobke
Copy link
Member

I like this a lot 👍 Especially on settings pages with a lot of a text between the sections it makes the layout more readable and easier to scan quickly.

@pixelipo pixelipo merged commit a92e8b4 into master Oct 3, 2018
@rullzer rullzer deleted the heading-bold branch October 3, 2018 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants