Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kinetic scrolling for iOS to apps dropdown menu #11111

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

kevin147147
Copy link
Contributor

this is tested with nc14

@kevin147147
Copy link
Contributor Author

#10281

@kevin147147 kevin147147 changed the title Added kinetic scrolling for iOS to apps dropdown menu #10281 Added kinetic scrolling for iOS to apps dropdown menu Sep 7, 2018
@ChristophWurst ChristophWurst added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Sep 10, 2018
@ChristophWurst
Copy link
Member

Btw, nice pull request id 😉

@skjnldsv
Copy link
Member

@kevin147147 I thought we already checked on the last pr and the kinetic scroll was already by default on the apple browsers? 🤔

@kevin147147
Copy link
Contributor Author

Kinetic scroll is always opt in as far as i know

@skjnldsv
Copy link
Member

Great addition for ios yes :)

@skjnldsv
Copy link
Member

@kevin147147 You need to sign your commit for the tests to pass :)

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works nicely 👍

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw it working @MorrisJobke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants