in 14 the click action gets lost in the Backbone view.

[blizzz]

fixes #10774 – tagging a file does not work with the second time you open the sidebar

I am not sure this is the best way to fix it, but it works. For this at least. There should be some reason why the click action gets unbound in 14, I don't know why though and don't know where to look. Thus, not sure whether this can be a problem for other FilePlugins.

[MorrisJobke]

Does not really work for me:

https://cloud.morrisjobke.de/s/B5CJKcNHbWKAyQa

As you can see the click on the "Tag" label triggers the dropdown of the tag element but does not change the visibility (not shown input just shows the dropdown and for a shown input the dropdown just switches on and off)

[MorrisJobke]

Or is this a different issue?

[blizzz]

@MorrisJobke different issue, and I could not observe it here. Going to spend another look at it, not sure i manager today/night
.

[MorrisJobke]

Then this breaks master for me - this is the same stuff on master, where I can at least open it once per page refresh: https://cloud.morrisjobke.de/s/ygYmJcTcMEpkajJ

[MorrisJobke]

Browser I tested in: Safari

[MorrisJobke]

Let's fix it later and backport.

[blizzz]

FYI, i come back to it asap, but busy with different other things :(

[blizzz]

Then this breaks master for me - this is the same stuff on master, where I can at least open it once per page refresh: https://cloud.morrisjobke.de/s/ygYmJcTcMEpkajJ

→ File not found

😿

[blizzz]

What I see on a QtWebEngine based browser is that after selecting a tag, it is shown on the upper left corner in the browser window. That's the only glitch, otherwise in works. In FF everything is shiny, however.

[blizzz]

What I see on a QtWebEngine based browser is that after selecting a tag, it is shown on the upper left corner in the browser window.

And the moment I tried to investigate it, it stopped to happen. Whyever.

Anybody else with Safari or who can do reproduce issues? Otherwise i'd vote for merging, as the state is at leat better than before.

[aaronjlawson]

@MorrisJobke Just curious, when this is fixed and merged will it also affect the NextCloud 14/Beta snap? Tags are only working once per page refresh for me as well. Ya'll probably already knew that though.

[MorrisJobke]

@MorrisJobke Just curious, when this is fixed and merged will it also affect the NextCloud 14/Beta snap? Tags are only working once per page refresh for me as well. Ya'll probably already knew that though.

Yes. Once fixed it will be in the next release. It seems to be 14.0.2 earliest though

[MorrisJobke]

@blizzz Any news on this one?

[blizzz]

@MorrisJobke still what I said in #10782 (comment) I have not found anyone else with Safari. But since, you're back ;) If you can reproduce it we can tackle that, otherwise merge.

[MorrisJobke]

Retested and works better than on master 👍

[MorrisJobke]

Let's revert as it breaks the sharing entries. See #11715 (review)