Check if TTY is invalid in encryption:encrypt-all and encryption:decrypt-all

[eugulixes]

Inspired by #9894.
The commands occ encryption:decrypt-all and occ encryption:encrypt-all transform into interactive processes since they both use ConfirmationQuestion. It's not possible to execute the commands in a container via docker exec without the -i and -t options. However, it becomes not obvious from a user point of view why since the result of both commands in this case is aborted. This PR tries to solve the problem.
Fixes #9894.

Signed-off-by: Evgeny Golyshev eugulixes@gmail.com

[nickvergessen]

windows is not supported anyway?

[eugulixes]

yeah, I suggest we will do nothing if we deal with Windows.

[jospoortvliet]

I would just remove this - that it breaks on windows is not a surprise, all of Nc breaks... Or should we keep it in @nickvergessen ?

[eugulixes]

The official documentation doesn't suggest Windows as an option, so it would be fair enough to remove the Windows-related checks.

[jospoortvliet]

@eugulixes go ahead, I suppose, if this was the only issue @nickvergessen had then it would suffice to get this ready to go.

[eugulixes]

Done.

[MorrisJobke]

Code looks good 👍 Tested and works

[rullzer]

Failing unit tests

[ChristophWurst]

Failing unit tests

Yeah, these built-in functions don't react well to phpunit (on CI?). I'd suggest to create a simple wrapper class for this that internally calls the php functions. This way we can mock them in unit tests. @eugulixes do you know how that works? I see this is your first contribution, so please let me know if you need assistance ✌️

That class would look something like

namespace OCP\Console;

class Environment {

    public function isInteractive(): bool {
        return posix_isatty(STDOUT);
    }
}

Inspiration was taken from https://github.com/sebastianbergmann/environment/blob/32c5cba90f7db47b1c10a777b36eccfd44ef8bd7/src/Console.php#L78, so that might also be an option to integrate. I've found traces of that class in my local dev setup.

[kesselb]

https://github.com/nextcloud/3rdparty/blob/461663cd1143c593fc71ee976afeb0f4e628b16b/symfony/console/Input/InputInterface.php#L153

You could use $input->isInteractive() like @ChristophWurst suggested

[ChristophWurst]

You could use $input->isInteractive() like @ChristophWurst suggested

Ha! Didn't know it was that simple! Thank you 😄

[ChristophWurst]

You could use $input->isInteractive() like @ChristophWurst suggested

@eugulixes ping :)

[eugulixes]

@ChristophWurst, i'm planning to do it this weekend.

[ChristophWurst]

Awesome, thanks!

[eugulixes]

@ChristophWurst, I used $input->isInteractive() instead of pure posix_isatty(STDOUT) and tested. It works fine, however the tests fail. What should I do in this case?

[kesselb]

$input->isInteractive() is false on ci.

server/tests/Core/Command/Encryption/DecryptAllTest.php

Line 75 in 9533f4e

$this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();

You need to mock isInteractive. Take the file above and look for the line and insert the following below:

$this->consoleInput->expects($this->any())
    ->method('isInteractive')
    ->willReturn(true);

I guess the same applies to

server/tests/Core/Command/Encryption/EncryptAllTest.php

Line 80 in 9533f4e

$this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();

[eugulixes]

@ChristophWurst, @danielkesselberg, all tests passed. Thank you for your help.