Rename group display names

[BornToBeRoot]

Add an edit button next to the delete button to rename groups?!

Currently i have to create a new group, add everyone to the group, delete the old one...

[MorrisJobke]

Group display names were implemented in #8255 - @nickvergessen it should be possible now to also implement the renaming, right?

[nickvergessen]

Well only displaying them. For 14 we should make it possible to store the displayname in the database.

[violoncelloCH]

something for 15 milestone?

[DerTomm]

... or 16 maybe? ;-)

[redtux]

What is needed for this to be implemented? It would really be great to be able to rename groups/roles. 👍

[violoncelloCH]

@redtux would you want to help out here?

@nickvergessen are the display names already stored in the database?

[redtux]

@violoncelloCH Depends on what needs to be done, as I am not a developer. Is this still related to #8255? (Is renaming possible in OwnCloud, so that I could have a look there?)

[nickvergessen]

No, there is currently only one column:
https://github.com/nextcloud/server/blob/master/core/Migrations/Version13000Date20170718121200.php#L253-L261

So the steps would be:

1. Add a migration to add a column to the oc_groups table
2. Copy the ID value to the name column
3. Adjust lib/private/Groups/ accordingly

The group object already has a dedicated method which should be used correctly everywhere.

[marshalleq]

Just registering my vote for this too. The original poster actually missed out some things from his steps obviously. Most importantly the need to copy the files into the new group and delete the old files. Not a very nice method.

[putt1ck]

Is this stalled?

[nickvergessen]

Well the backend is already done, it's just missing someone to pick up the task to add it to the frontend

[tigattack]

It would be great if this could be added 🙂

[fenvarien]

With many schools successfully using Nextcloud, and with more and more schools starting to use it during the pandemic, we really need this feature usable and accessible from the frontend. Otherwise the end of the school year could become quite problematic and a disappointing experience for many teachers who convinced their colleagues and principal to use Nextcloud.

[b3]

Is there anyway to financially sponsor the work (paying Nextcloud to implement the frontend access to group renaming)?

[ArcticFall]

I would be willing to work on it, because my organization needs this feature.

I was thinking to add an edit button (same as the user edit button) left of the delete button and open a popover where the new name can be typed.

But I'm completely new to contributing to nextcloud and am not too farmiliar with Vue. So any pointers would be nice!

[redtux]

@ArcticFall Great news, I think that what @nickvergessen wrote in a comment above is still a good starting point. See #9209 (comment)

[ArcticFall]

The backend functionality mentioned in #9209 (comment) is already implemented, as far as I can see. The database has the new column, which currently has the same value as the group id. Changing the display name in the database seems to also have an effect in the frontend.

So I think only the frontend needs to be altered, to include functionality to change the display name form there.

[ArcticFall]

I think I found the right places to address this. See 7cf96e2 and 42464e9.
But these changes aren't showing in my development instance of nextcloud. Do I need to do something first to see those changes?

[nickvergessen]

Make sure you have node14 and npm7 installed and then follow this part of the readme to compile the src folder into the new js files
https://github.com/nextcloud/server#working-with-front-end-code-

In your case MODULE=settings should help

[ArcticFall]

I figured out the frontend and js stuff and got it working until the point I actually have to make a request to the backend to change it.
But I have not been able to figure out, where to find the API documentation for that or where I would have to implement an endpoint. If anybody could help me out, that would be great.

I looked at the OCS documentation, but the user/group related stuff seems to be undocumented.

[ArcticFall]

@nickvergessen could you give me a pointer? I wasn't able to find anything and nobody answered on the forum either...

[nickvergessen]

Group and user stuff is in the admin docs
https://docs.nextcloud.com/server/latest/admin_manual/configuration_user/instruction_set_for_groups.html

But also there the rename is missing.

https://github.com/nextcloud/server/blob/master/apps/provisioning_api/appinfo/routes.php#L44

Its a put agains the group endpoint
Parameters are key=displayname and value=THe Input
https://github.com/nextcloud/server/blob/master/apps/provisioning_api/lib/Controller/GroupsController.php#L269

[ArcticFall]

Thanks! I got everything working.
Now just making sure that everything looks good frontend wise and I can make a pull request.

[ArcticFall]

Closed with #30043

[kdoteu]

I'm new to the Nextcloud release cycle. When will this feature propably in the beta or specially in the stable channel?

[nickvergessen]

Beta in 2 days, stable in roughly 6 weeks
https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule