-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome autofill fills in password on sharelinks with login password #6821
Comments
Browser vendors are going more and more insane with their autocompletion.
did you try this? Mind opening a pull request? |
Nope, still haven't tried it. |
Fixes #6821 This makes sure that (supported) browsers will not prefill the password field if a user has a password saved for that nextcloud. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
PR in #6947 |
Sorry but I cannot understand why this issue is already closed. When I take a look at the current master, the password input field for a shared link doesn't have the attribute autocomplete="new-password". I have the problem with the password input field when creating a new shared link ("Choose a password for the public link"). Steps to reproduce:
Adding the attribute autocomplete=“new-password” for the password field would fix this issue, too. |
@stephan-a aaah I had the wrong field in mind... I'll fix this later |
@rullzer Ping |
Fixes #6821 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
At least as some sort of minimal protection "Share as public link" should not automatically be checked and submitted when there is a (maybe accidently typed) password. |
Steps to reproduce
Expected behaviour
Password should be set by the user if they want any
Actual behaviour
Chrome adds the login password as password for the share link
Server configuration
Operating system:
Ubuntu 16.04
Web server:
Apache2
Database:
Mariadb
PHP version:
php7.0
Nextcloud version: (see Nextcloud admin page)
12.0.3
Updated from an older Nextcloud/ownCloud or fresh install:
11.0.3
The solution is to add autocomplete=“new-password” to the password field.
The text was updated successfully, but these errors were encountered: