Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround when selecting "edit locally" as an option #46438

Closed
sorbaugh opened this issue Jul 11, 2024 · 0 comments · Fixed by #46452
Closed

Workaround when selecting "edit locally" as an option #46438

sorbaugh opened this issue Jul 11, 2024 · 0 comments · Fixed by #46452
Assignees
@nfebe
Labels
2. developing Work in progress enhancement

Comments

@sorbaugh
Copy link
Contributor

sorbaugh commented Jul 11, 2024 •
edited
Loading

When selecting "edit locally" as an option, we cannot know if the client is installed on the OS (that's just not possible).

richdocument has a nice way around that, we need to do the same here: https://github.com/nextcloud/server/blob/master/apps/files/src/actions/editLocallyAction.ts

Richdocs solution: https://github.com/nextcloud/richdocuments/blob/main/src/mixins/openLocal.js#L57-L73
@sorbaugh sorbaugh added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 11, 2024
@sorbaugh sorbaugh changed the title Workaround when selecting "edit locally" as an option, we cannot know if the client is installed on the OS (that's just not possible) Workaround when selecting "edit locally" as an option Jul 11, 2024
nfebe added a commit that referenced this issue Jul 11, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
8e99420 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe mentioned this issue Jul 11, 2024
Merged
1 task
@susnux susnux added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 11, 2024
nfebe added a commit that referenced this issue Jul 11, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
6f03aff 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 11, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
6a5d941 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 11, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
1993179 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 11, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
2def870 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 11, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
3f4cd16 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 11, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
c1e98f5 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 11, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
a113d41 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 12, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
c45e176 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 12, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
ec08839 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 12, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
ce7055b 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 12, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
0ef4ad3 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 15, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
43aade3 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 15, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
9ad0a2b 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 16, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
038b40b 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 17, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
0b526e1 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 17, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
0274821 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 31, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
3d2592a 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe closed this as completed in 267ae6f Jul 31, 2024
backportbot bot pushed a commit that referenced this issue Jul 31, 2024
@nfebe @backportbot
feat(editLocallyAction): Handle possible no local client scenario
26db929 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
backportbot bot pushed a commit that referenced this issue Jul 31, 2024
@nfebe @backportbot
feat(editLocallyAction): Handle possible no local client scenario
4d9ba27 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Jul 31, 2024
@nfebe
feat(editLocallyAction): Handle possible no local client scenario
c8a36ab 
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfebe nfebe

Labels
2. developing Work in progress enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(editLocallyAction): Handle possible no local client scenario nextcloud/server
3 participants
@susnux @nfebe @sorbaugh