Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚢 Ship composer and package lock files #40072

Closed
AndyScherzinger opened this issue Aug 28, 2023 · 6 comments
Closed

🚢 Ship composer and package lock files #40072

AndyScherzinger opened this issue Aug 28, 2023 · 6 comments
Assignees
@blizzz
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement
Milestone
Nextcloud 27.1.0

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 28, 2023 •
edited
Loading

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Currently it is not possible to run a license scan on a package/build since we do not ship composer.lock and package-lock.json.

Describe the solution you'd like
Ship composer and package lock-files in our release archives for server and the apps in the release archive(s)

Describe alternatives you've considered
Currently none. A scan would be possible based on the release tags while that is not the same source as being able to do this based on the content of a release tar-ball.
@AndyScherzinger AndyScherzinger added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 28, 2023
@AndyScherzinger AndyScherzinger moved this to 📄 To do (~10 entries) in 📁 Files team Aug 28, 2023
@AndyScherzinger AndyScherzinger changed the title Ship composer and package lock files 🚢 Ship composer and package lock files Aug 28, 2023
@AndyScherzinger AndyScherzinger moved this to 📄 To do (~10 entries) in 📝 Office team Aug 30, 2023
@blizzz blizzz self-assigned this Aug 30, 2023
@nickvergessen nickvergessen mentioned this issue Aug 31, 2023
Merged
@AndyScherzinger AndyScherzinger moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📁 Files team Aug 31, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 27.1.0 milestone Aug 31, 2023
@AndyScherzinger
Copy link
Member Author

Afaik done, no? @juliushaertl

@juliusknorr
Copy link
Member

Server bit not merged yet.

@blizzz
Copy link
Member

blizzz commented Sep 5, 2023

Server bit not merged yet.

link?

@juliusknorr
Copy link
Member

Sorry was referring to the release script not server https://github.com/nextcloud-gmbh/release-script/pull/132

@blizzz
Copy link
Member

blizzz commented Sep 5, 2023

that makes sense. yes, still on me list.

@AndyScherzinger
Copy link
Member Author

Merged, thanks @blizzz closing as resolved then 👍

@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Sep 5, 2023
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Sep 5, 2023
Rello added a commit to nextcloud/integration_swp that referenced this issue Sep 11, 2023
@Rello
Update makefile to keep packaging files
533ea69 
nextcloud/server#40072

Signed-off-by: Rello <Rello@users.noreply.github.com>
@Rello Rello mentioned this issue Sep 11, 2023
Merged
Rello added a commit to nextcloud/integration_openproject that referenced this issue Sep 11, 2023
@Rello
Update makefile to keep packaging files
86d04d0 
nextcloud/server#40072

Signed-off-by: Rello <Rello@users.noreply.github.com>
@Rello Rello mentioned this issue Sep 11, 2023
Merged
julien-nc pushed a commit to nextcloud/integration_openproject that referenced this issue Sep 12, 2023
@Rello @julien-nc
Update makefile to keep packaging files
238d727 
nextcloud/server#40072

Signed-off-by: Rello <Rello@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blizzz blizzz

Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement
Projects
📁 Files team
Archived in project
📝 Office team
Archived in project
Milestone
Nextcloud 27.1.0
Development

No branches or pull requests
3 participants
@AndyScherzinger @blizzz @juliusknorr