Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic operation "free_space" is not implemented #28450

Closed
SpamReceiver opened this issue Aug 16, 2021 · 1 comment
Closed

Basic operation "free_space" is not implemented #28450

SpamReceiver opened this issue Aug 16, 2021 · 1 comment

Comments

@SpamReceiver
Copy link
Contributor

SpamReceiver commented Aug 16, 2021

$result = $this->basicOperation('free_space', $path);

The function public function free_space($path = '/') calls $this->basicOperation('free_space', $path); but basicOperation doesn't implement the operation "free_space" and hence always returns null.

In consequence, no free disk space is calculated and e.g. the trashbin retention will keep files forever.

@kesselb
Copy link
Contributor

kesselb commented Aug 16, 2021

	/**
	 * abstraction layer for basic filesystem functions: wrapper for \OC\Files\Storage\Storage
	 *
	 * This method takes requests for basic filesystem functions (e.g. reading & writing
	 * files), processes hooks and proxies, sanitises paths, and finally passes them on to
	 * \OC\Files\Storage\Storage for delegation to a storage backend for execution
	 */
         private function basicOperation($operation, $path, $hooks = [], $extraParam = null) {

At least for local storage free_space is correctly forwarded. I'm closing your report. Feel free to create a proper report using the issue template and include for which storage free_space is not implemented.

@kesselb kesselb closed this as completed Aug 16, 2021
SpamReceiver added a commit to SpamReceiver/server that referenced this issue Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants