Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File sorting should allow option to not list favorites first. #18700

Closed
thorsten19 opened this issue Jan 6, 2020 · 11 comments
Closed

File sorting should allow option to not list favorites first. #18700

thorsten19 opened this issue Jan 6, 2020 · 11 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement

Comments

@thorsten19
Copy link

thorsten19 commented Jan 6, 2020

Steps to reproduce

  1. In the files application sort a folder or file list containing a file or folder marked as favorite.
  2. Files are always sorted with the item marked as favorite first, then showing other files/forders as per the sort criteria.

Actual Behaviour
Sorted file lists always show favorite folders/files first.
I did not know this and first thought the sorting function (by name, date and size) would have a bug. I then found that this was added as feature but seems not configurable.
#1802

Expected Behaviour
While the current sorting showing favorite files/folders first might be useful in many situations, the file function should have a feature to enable/disable this sorting behaviour and allow a regular sorting (aka disregard in the sorting if a file is marked as favorite)
Maybe this feature can be combined with the request to add new "Sort by Filters" listed here? #18426

Thanks!

Configuration

Nextcloud version:
17.0.2

@thorsten19 thorsten19 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Jan 6, 2020
@kesselb
Copy link
Contributor

kesselb commented Jan 6, 2020

cc @jancborchardt

@jancborchardt
Copy link
Member

in many situations the file function should have a feature to enable/disable this sorting behaviour and allow a regular sorting

Could you give some specific examples or describe why favorites are not important in specific cases?

@thorsten19
Copy link
Author

Thanks @jancborchardt.
Example: You want to do a sort by the file size or age of the file as you search for the biggest/oldest/newest file in a directory.
Imagine now you have not one but several files/folders marked as favorites.

If the webview does not allow to change the sorting behaviour, the only way two options are to either

  • to remove the favorite tag for the file(s)/folder(s), then the list can be fully sorted in the Webview
  • to sync all files to a another machine (for example using the Nextcloud sync agent) and sort in the target machine.
    Both options are not user friendly. An option to allow "ignore favorites when sorting" would be pragmatic.

@siccovansas
Copy link

Another example. I favorite my best images. While most of the time you indeed would like to see your favorite images first in the folder, sometimes you would like to see all image chronologically. This is currently not possible.

@skjnldsv

This comment has been minimized.

@ghost ghost added the stale Ticket or PR with no recent activity label Dec 7, 2020
@thorsten19

This comment has been minimized.

@ghost ghost removed the stale Ticket or PR with no recent activity label Dec 8, 2020
@skjnldsv

This comment has been minimized.

@ghost ghost added the stale Ticket or PR with no recent activity label Jan 7, 2021
@siccovansas

This comment has been minimized.

@ghost ghost removed the stale Ticket or PR with no recent activity label Jan 7, 2021
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jan 8, 2021
@nextcloud nextcloud deleted a comment Jan 8, 2021
@nextcloud nextcloud deleted a comment Jan 8, 2021
@Simon-Spettmann
Copy link

If someone is looking for a quick workaround to disable this for the web interface:
Remove or comment out the following code in ./apps/files/js/fileslist.js -> setSort: function(...)

if (isFavorite(fileInfo1) && !isFavorite(fileInfo2)) { return -1; } else if (!isFavorite(fileInfo1) && isFavorite(fileInfo2)) { return 1; }

@emes81
Copy link

emes81 commented Nov 19, 2022

in many situations the file function should have a feature to enable/disable this sorting behaviour and allow a regular sorting

Could you give some specific examples or describe why favorites are not important in specific cases?

I think it's notable that no similar interface of which I'm aware (Dropbox, GDrive, OneDrive) does this, nor does any file manager I use (Windows File Explorer, Nautilus, various Android).

Both in the mobile app and the web UI, Nextcloud already has favourites in the sidebar, in a way analogous to quick access, starred etc. in other services/apps. So not only is pinning favourited folders/files to the top of a list superfluous; it also reduces other functionality (ability to sort all folders incl. favourited ones by name/date/size etc).

So the two ways of accessing favourites pinned to the top of a file/folder list are either superfluous (as the user reaches the folder via the sidebar favourites list anyway) or cumbersome (user has already had to navigate through nested folders to reach the favourite).

I stopped using favourites in NC because it made it harder for me to find things (as i was looking for the "media" folder in its alphabetical location, not at the top, because that's where it is in Nautilus, File Explorer, etc.). Favourites are important: making them quickly accessible should not mean that they also have reduced functionality.

@skjnldsv skjnldsv mentioned this issue Aug 16, 2023
26 tasks
@skjnldsv
Copy link
Member

In 28

@skjnldsv skjnldsv moved this to Done in Files to vue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement
Projects
Status: Done
Development

No branches or pull requests

7 participants