Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort favorite files first in the list #1802

Closed
jancborchardt opened this issue Oct 19, 2016 · 9 comments
Closed

Sort favorite files first in the list #1802

jancborchardt opened this issue Oct 19, 2016 · 9 comments

Comments

@jancborchardt
Copy link
Member

Favoriting is not very integrated at the moment. Only an indicator, we can do better here.

Better integration without needing to switch to a separate view would be to always sort the favorited items of a the current folder up top.

Already done in Android, ref nextcloud/android#107 @nextcloud/javascript

@nickvergessen
Copy link
Member

Just noting: the web UI get files in batches, so when you scroll down it preloads more files. But this means that the initial list of files may not contain all your favorites. SO only "some" will appear at teh top, unless this is added fully to the api, in which case n/javascript is the wrong mention. 😦

@jancborchardt
Copy link
Member Author

Ah ok – how do we get the favorites in the files filter then? We should do it like there. cc @icewind1991

@nickvergessen
Copy link
Member

The filter uses a completly different endpoint

@ryanwr
Copy link
Contributor

ryanwr commented Oct 21, 2016

I think the sorting should be done server side, I think I've got an idea of how to do it, I'll have a go

@ryanwr
Copy link
Contributor

ryanwr commented Oct 22, 2016

@nickvergessen I'm not sure if I'm missing something but does the client receive batches of files from the webdav server? How does the webdav server paginate requests?

@ChristophWurst
Copy link
Member

@ryanwr the pagination is done on the client, which means the folder content it fetched with a single webdav request AFAIK.

@ryanwr
Copy link
Contributor

ryanwr commented Oct 22, 2016

@ChristophWurst Thanks! That's helpful

@ryanwr
Copy link
Contributor

ryanwr commented Oct 22, 2016

Opened a PR, I'd appreciate feedback on it!

@rullzer
Copy link
Member

rullzer commented Oct 25, 2016

Merged in #1860 thanks @ryanwr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants