-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort favorite files first in the list #1802
Comments
Just noting: the web UI get files in batches, so when you scroll down it preloads more files. But this means that the initial list of files may not contain all your favorites. SO only "some" will appear at teh top, unless this is added fully to the api, in which case n/javascript is the wrong mention. 😦 |
Ah ok – how do we get the favorites in the files filter then? We should do it like there. cc @icewind1991 |
The filter uses a completly different endpoint |
I think the sorting should be done server side, I think I've got an idea of how to do it, I'll have a go |
@nickvergessen I'm not sure if I'm missing something but does the client receive batches of files from the webdav server? How does the webdav server paginate requests? |
@ryanwr the pagination is done on the client, which means the folder content it fetched with a single webdav request AFAIK. |
@ChristophWurst Thanks! That's helpful |
Opened a PR, I'd appreciate feedback on it! |
Favoriting is not very integrated at the moment. Only an indicator, we can do better here.
Better integration without needing to switch to a separate view would be to always sort the favorited items of a the current folder up top.
Already done in Android, ref nextcloud/android#107 @nextcloud/javascript
The text was updated successfully, but these errors were encountered: