fix: Avoid reference use in AppConfig

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nextcloud · Apr 29, 2024 · f265f21 · f265f21
1 parent 7f2a1fa
commit f265f21
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/private/AppConfig.php b/lib/private/AppConfig.php
@@ -850,11 +850,10 @@ private function setTypedValue(
 
 		// update local cache
 		if ($lazy) {
-			$cache = &$this->lazyCache;
+			$this->lazyCache[$app][$key] = $value;
 		} else {
-			$cache = &$this->fastCache;
+			$this->fastCache[$app][$key] = $value;
 		}
-		$cache[$app][$key] = $value;
 		$this->valueTypes[$app][$key] = $type;
 
 		return true;
@@ -1264,11 +1263,10 @@ private function loadConfig(?bool $lazy = false): void {
 		foreach ($rows as $row) {
 			// most of the time, 'lazy' is not in the select because its value is already known
 			if (($row['lazy'] ?? ($lazy ?? 0) ? 1 : 0) === 1) {
-				$cache = &$this->lazyCache;
+				$this->lazyCache[$row['appid']][$row['configkey']] = $row['configvalue'] ?? '';
 			} else {
-				$cache = &$this->fastCache;
+				$this->fastCache[$row['appid']][$row['configkey']] = $row['configvalue'] ?? '';
 			}
-			$cache[$row['appid']][$row['configkey']] = $row['configvalue'] ?? '';
 			$this->valueTypes[$row['appid']][$row['configkey']] = (int)($row['type'] ?? 0);
 		}
 		$result->closeCursor();