Merge pull request #32424 from nextcloud/backport/32382/stable24

[stable24] only log diagnostic events if a treshhold is set
nextcloud · May 16, 2022 · ee89136 · ee89136
2 parents 4efd0cd + 30b0a02
commit ee89136
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/config/config.sample.php b/config/config.sample.php
@@ -2128,6 +2128,8 @@
 
 /**
  * Limit diagnostics event logging to events longer than the configured threshold in ms
+ *
+ * when set to 0 no diagnostics events will be logged
  */
 'diagnostics.logging.threshold' => 0,
 

diff --git a/lib/private/Diagnostics/EventLogger.php b/lib/private/Diagnostics/EventLogger.php
@@ -126,7 +126,7 @@ private function writeLog(IEvent $event) {
 			$timeInMs = round($duration * 1000, 4);
 
 			$loggingMinimum = (int)$this->config->getValue('diagnostics.logging.threshold', 0);
-			if ($loggingMinimum > 0 && $timeInMs < $loggingMinimum) {
+			if ($loggingMinimum === 0 || $timeInMs < $loggingMinimum) {
 				return;
 			}
-Original file line number
+Diff line change
@@ Expand Up / @@ -2128,6 +2128,8 @@ @@
     /**
      * Limit diagnostics event logging to events longer than the configured threshold in ms
+     *
+     * when set to 0 no diagnostics events will be logged
      */
     'diagnostics.logging.threshold' => 0,
@@ Expand Down @@