Skip to content

Commit

Permalink
Use noreply@ as email address for share emails
Browse files Browse the repository at this point in the history
Fixes #26683

Before it used the instance name, which a) doesn't make sense to randomly guess email addresses and b) could contain characters that are not allowed in email addresses like spaces.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
  • Loading branch information
MorrisJobke authored and backportbot[bot] committed May 28, 2021
1 parent b7fbab8 commit d1e5039
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/private/Share20/Manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ protected function sendMailNotification(IL10N $l,
$instanceName
]
);
$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
$message->setFrom([\OCP\Util::getDefaultEmailAddress('noreply') => $senderName]);

// The "Reply-To" is set to the sharer if an mail address is configured
// also the default footer contains a "Do not reply" which needs to be adjusted.
Expand Down

0 comments on commit d1e5039

Please sign in to comment.