Skip to content

Commit

Permalink
fix(setupcheck): Update setup check for PHP version to be more accurate
Browse files Browse the repository at this point in the history
Signed-off-by: Joas Schilling <coding@schilljs.com>
  • Loading branch information
nickvergessen committed Feb 8, 2025
1 parent 86276e3 commit c3fc42e
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion apps/settings/lib/SetupChecks/PhpOutdated.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
use OCP\SetupCheck\SetupResult;

class PhpOutdated implements ISetupCheck {
public const DEPRECATED_PHP_VERSION = '8.1';
public const DEPRECATED_SINCE = '30';
public const FUTURE_REQUIRED_PHP_VERSION = '8.2';
public const FUTURE_REQUIRED_STARTING = '32';

public function __construct(
private IL10N $l10n,
) {
Expand All @@ -29,7 +34,13 @@ public function getName(): string {

public function run(): SetupResult {
if (PHP_VERSION_ID < 80200) {
return SetupResult::warning($this->l10n->t('You are currently running PHP %s. PHP 8.1 is now deprecated in Nextcloud 30. Nextcloud 31 may require at least PHP 8.2. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [PHP_VERSION]), 'https://secure.php.net/supported-versions.php');
return SetupResult::warning($this->l10n->t('You are currently running PHP %s. PHP %s is deprecated since Nextcloud %d. Nextcloud %s may require at least PHP %s. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [
PHP_VERSION,
self::DEPRECATED_PHP_VERSION,
self::DEPRECATED_SINCE,
self::FUTURE_REQUIRED_STARTING,
self::FUTURE_REQUIRED_PHP_VERSION,
]), 'https://secure.php.net/supported-versions.php');
}
return SetupResult::success($this->l10n->t('You are currently running PHP %s.', [PHP_VERSION]));
}
Expand Down

0 comments on commit c3fc42e

Please sign in to comment.