More explicit empty profile message

Signed-off-by: Christopher Ng <chrng8@gmail.com>
nextcloud · Dec 17, 2021 · a3acf02 · a3acf02
1 parent 1949813
commit a3acf02
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/apps/settings/src/constants/AccountPropertyConstants.js b/apps/settings/src/constants/AccountPropertyConstants.js
@@ -48,7 +48,7 @@ export const ACCOUNT_PROPERTY_ENUM = Object.freeze({
 export const ACCOUNT_PROPERTY_READABLE_ENUM = Object.freeze({
 	ADDRESS: t('settings', 'Address'),
 	AVATAR: t('settings', 'Avatar'),
-	BIOGRAPHY: t('settings', 'About'),
+	BIOGRAPHY: t('settings', 'Biography'),
 	DISPLAYNAME: t('settings', 'Full name'),
 	EMAIL_COLLECTION: t('settings', 'Additional email'),
 	EMAIL: t('settings', 'Email'),

diff --git a/core/src/views/Profile.vue b/core/src/views/Profile.vue
@@ -141,8 +141,8 @@
 							title=""
 							fill-color="var(--color-text-maxcontrast)"
 							:size="60" />
-						<h3>{{ emptyProfileMessage }}</h3>
-						<p>{{ t('core', 'The headline and about sections will show up here') }}</p>
+						<h3>{{ emptyProfileHeading }}</h3>
+						<p>{{ emptyProfileMessage }}</p>
 					</div>
 				</template>
 			</div>
@@ -256,10 +256,16 @@ export default {
 			return getComputedStyle(document.body).getPropertyValue('--color-main-background').trim()
 		},
 
+		emptyProfileHeading() {
+			return this.isCurrentUser
+				? t('core', 'You haven\'t added a headline or biography yet')
+				: t('core', '{user} hasn\'t added a headline or biography yet', { user: (this.displayname || this.userId) })
+		},
+
 		emptyProfileMessage() {
 			return this.isCurrentUser
-				? t('core', 'You haven\'t added any info yet')
-				: t('core', '{user} hasn\'t added any info yet', { user: (this.displayname || this.userId) })
+				? t('core', 'Your added info will show up here')
+				: t('core', 'Added info of {user} will show up here', { user: (this.displayname || this.userId) })
 		},
 	},
 

diff --git a/lib/private/Profile/ProfileManager.php b/lib/private/Profile/ProfileManager.php
@@ -404,7 +404,7 @@ public function getProfileConfigWithMetadata(IUser $targetUser, ?IUser $visiting
 			],
 			IAccountManager::PROPERTY_BIOGRAPHY => [
 				'appId' => self::CORE_APP_ID,
-				'displayId' => $this->l10nFactory->get('lib')->t('About'),
+				'displayId' => $this->l10nFactory->get('lib')->t('Biography'),
 			],
 			IAccountManager::PROPERTY_DISPLAYNAME => [
 				'appId' => self::CORE_APP_ID,