Additional index on oc_preferences to make sure that gettingh values …

…without a user filter is fast Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Apr 19, 2022 · 7fbd93b · 7fbd93b
1 parent cd95fce
commit 7fbd93b
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 0 deletions.
diff --git a/core/Application.php b/core/Application.php
@@ -213,6 +213,13 @@ function (GenericEvent $event) use ($container) {
 						$subject->addHintForMissingSubject($table->getName(), 'direct_edit_timestamp');
 					}
 				}
+
+				if ($schema->hasTable('preferences')) {
+					$table = $schema->getTable('preferences');
+					if (!$table->hasIndex('preferences_app_key')) {
+						$subject->addHintForMissingSubject($table->getName(), 'preferences_app_key');
+					}
+				}
 			}
 		);
 

diff --git a/core/Command/Db/AddMissingIndices.php b/core/Command/Db/AddMissingIndices.php
@@ -435,6 +435,19 @@ private function addCoreIndexes(OutputInterface $output, bool $dryRun): void {
 			}
 		}
 
+		$output->writeln('<info>Check indices of the oc_preferences table.</info>');
+		if ($schema->hasTable('preferences')) {
+			$table = $schema->getTable('preferences');
+			if (!$table->hasIndex('preferences_app_key')) {
+				$output->writeln('<info>Adding preferences_app_key index to the oc_preferences table, this can take some time...</info>');
+
+				$table->addIndex(['appid', 'configkey'], 'preferences_app_key');
+				$this->connection->migrateToSchema($schema->getWrappedSchema());
+				$updated = true;
+				$output->writeln('<info>oc_properties table updated successfully.</info>');
+			}
+		}
+
 		if (!$updated) {
 			$output->writeln('<info>Done.</info>');
 		}

diff --git a/core/Migrations/Version13000Date20170718121200.php b/core/Migrations/Version13000Date20170718121200.php
@@ -333,6 +333,7 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op
 				'notnull' => false,
 			]);
 			$table->setPrimaryKey(['userid', 'appid', 'configkey']);
+			$table->addIndex(['appid', 'configkey'], 'preferences_app_key');
 		}
 
 		if (!$schema->hasTable('properties')) {

diff --git a/lib/private/AllConfig.php b/lib/private/AllConfig.php
@@ -497,6 +497,8 @@ public function getUsersForUserValue($appName, $key, $value) {
 			$sql .= 'AND `configvalue` = ?';
 		}
 
+		$sql .= ' ORDER BY `userid`';
+
 		$result = $this->connection->executeQuery($sql, [$appName, $key, $value]);
 
 		$userIDs = [];
@@ -534,6 +536,8 @@ public function getUsersForUserValueCaseInsensitive($appName, $key, $value) {
 			$sql .= 'AND LOWER(`configvalue`) = ?';
 		}
 
+		$sql .= ' ORDER BY `userid`';
+
 		$result = $this->connection->executeQuery($sql, [$appName, $key, strtolower($value)]);
 
 		$userIDs = [];