Skip to content

Commit

Permalink
only log diagnostic events if a treshhold is set
Browse files Browse the repository at this point in the history
this prevents log spam and it's rare that you actually want to very short events logged anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>
  • Loading branch information
icewind1991 committed May 13, 2022
1 parent 52bb29b commit 6852047
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion config/config.sample.php
Original file line number Diff line number Diff line change
Expand Up @@ -1791,7 +1791,7 @@

/**
* Enforce the user theme. This will disable the user theming settings
* This must be a valid ITheme ID.
* This must be a valid ITheme ID.
* E.g. light, dark, highcontrast, dark-highcontrast...
*/
'enforce_theme' => '',
Expand Down Expand Up @@ -2146,6 +2146,8 @@

/**
* Limit diagnostics event logging to events longer than the configured threshold in ms
*
* when set to 0 no diagnostics events will be logged
*/
'diagnostics.logging.threshold' => 0,

Expand Down
2 changes: 1 addition & 1 deletion lib/private/Diagnostics/EventLogger.php
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private function writeLog(IEvent $event) {
$timeInMs = round($duration * 1000, 4);

$loggingMinimum = (int)$this->config->getValue('diagnostics.logging.threshold', 0);
if ($loggingMinimum > 0 && $timeInMs < $loggingMinimum) {
if ($loggingMinimum == 0 || $timeInMs < $loggingMinimum) {
return;
}

Expand Down

0 comments on commit 6852047

Please sign in to comment.