Skip to content

Commit

Permalink
Merge pull request #33394 from nextcloud/fix/fix-370-Label_not_connec…
Browse files Browse the repository at this point in the history
…ted_to_form-element_in_file_listing

Connect ```input``` checkbox with corresponding file name via ```aria-describedby```
  • Loading branch information
JuliaKirschenheuter authored Jul 28, 2022
2 parents ee23f41 + ef3fb28 commit 532ea00
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions apps/files/js/filelist.js
Original file line number Diff line number Diff line change
Expand Up @@ -1694,7 +1694,7 @@

td.append(
'<input id="select-' + this.id + '-' + fileData.id +
'" type="checkbox" class="selectCheckBox checkbox"/><label for="select-' + this.id + '-' + fileData.id + '">' +
'" type="checkbox" class="selectCheckBox checkbox" aria-describedby="innernametext_' + fileData.id + '" /><label for="select-' + this.id + '-' + fileData.id + '">' +
'<span class="hidden-visually">' + (fileData.type === 'dir' ?
t('files', 'Select directory "{dirName}"', {dirName: name}) :
t('files', 'Select file "{fileName}"', {fileName: name})) + '</span>' +
Expand Down Expand Up @@ -1744,8 +1744,9 @@
basename = name;
extension = false;
}
var nameSpan=$('<span></span>').addClass('nametext');
var innernameSpan = $('<span></span>').addClass('innernametext').text(basename).prop('title', basename);
var nameSpan=$('<span></span>').addClass('nametext')

var innernameSpan = $('<span></span>').addClass('innernametext').text(basename).prop('title', basename).prop('id', `innernametext_${fileData.id}`);


var conflictingItems = this.$fileList.find('tr[data-file="' + this._jqSelEscape(name) + '"]');
Expand Down

0 comments on commit 532ea00

Please sign in to comment.