-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #41438 from nextcloud/feat/migrate-forwarded-for-h…
…eaders-check Migrate forwarded for headers check
- Loading branch information
Showing
10 changed files
with
249 additions
and
198 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * @copyright Copyright (c) 2023 Côme Chilliet <come.chilliet@nextcloud.com> | ||
| * | ||
| * @author Côme Chilliet <come.chilliet@nextcloud.com> | ||
| * | ||
| * @license GNU AGPL version 3 or any later version | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as | ||
| * published by the Free Software Foundation, either version 3 of the | ||
| * License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| * | ||
| */ | ||
|
|
||
| namespace OCA\Settings\SetupChecks; | ||
|
|
||
| use OCP\IConfig; | ||
| use OCP\IL10N; | ||
| use OCP\IRequest; | ||
| use OCP\IURLGenerator; | ||
| use OCP\SetupCheck\ISetupCheck; | ||
| use OCP\SetupCheck\SetupResult; | ||
|
|
||
| class ForwardedForHeaders implements ISetupCheck { | ||
| public function __construct( | ||
| private IL10N $l10n, | ||
| private IConfig $config, | ||
| private IURLGenerator $urlGenerator, | ||
| private IRequest $request, | ||
| ) { | ||
| } | ||
|
|
||
| public function getCategory(): string { | ||
| return 'security'; | ||
| } | ||
|
|
||
| public function getName(): string { | ||
| return $this->l10n->t('Forwared for headers'); | ||
| } | ||
|
|
||
| public function run(): SetupResult { | ||
| $trustedProxies = $this->config->getSystemValue('trusted_proxies', []); | ||
| $remoteAddress = $this->request->getHeader('REMOTE_ADDR'); | ||
| $detectedRemoteAddress = $this->request->getRemoteAddress(); | ||
|
|
||
| if (!\is_array($trustedProxies)) { | ||
| return SetupResult::error($this->l10n->t('Your trusted_proxies setting is not correctly set, it should be an array.')); | ||
| } | ||
|
|
||
| if (($remoteAddress === '') && ($detectedRemoteAddress === '')) { | ||
| if (\OC::$CLI) { | ||
| /* We were called from CLI */ | ||
| return SetupResult::info($this->l10n->t('Your remote address could not be determined.')); | ||
| } else { | ||
| /* Should never happen */ | ||
| return SetupResult::error($this->l10n->t('Your remote address could not be determined.')); | ||
| } | ||
| } | ||
|
|
||
| if (empty($trustedProxies) && $this->request->getHeader('X-Forwarded-Host') !== '') { | ||
| return SetupResult::error( | ||
| $this->l10n->t('The reverse proxy header configuration is incorrect. This is a security issue and can allow an attacker to spoof their IP address as visible to the Nextcloud.'), | ||
| $this->urlGenerator->linkToDocs('admin-reverse-proxy') | ||
| ); | ||
| } | ||
|
|
||
| if (\in_array($remoteAddress, $trustedProxies, true) && ($remoteAddress !== '127.0.0.1')) { | ||
| if ($remoteAddress !== $detectedRemoteAddress) { | ||
| /* Remote address was successfuly fixed */ | ||
| return SetupResult::success($this->l10n->t('Your IP address was resolved as %s', [$detectedRemoteAddress])); | ||
| } else { | ||
| return SetupResult::warning( | ||
| $this->l10n->t('The reverse proxy header configuration is incorrect, or you are accessing Nextcloud from a trusted proxy. If not, this is a security issue and can allow an attacker to spoof their IP address as visible to the Nextcloud.'), | ||
| $this->urlGenerator->linkToDocs('admin-reverse-proxy') | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| /* Either not enabled or working correctly */ | ||
| return SetupResult::success(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.