Apply suggestions from code review

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
nextcloud · Sep 21, 2023 · 0273b96 · 0273b96
1 parent 90652fd
commit 0273b96
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/apps/files_versions/lib/Command/CleanUp.php b/apps/files_versions/lib/Command/CleanUp.php
@@ -115,7 +115,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 	/**
 	 * delete versions for the given user
 	 */
-	protected function deleteVersions(string $user, string $path = null): void {
+	protected function deleteVersions(string $user, ?string $path = null): void {
 		\OC_Util::tearDownFS();
 		\OC_Util::setupFS($user);
 

diff --git a/apps/files_versions/lib/Command/Expire.php b/apps/files_versions/lib/Command/Expire.php
@@ -53,7 +53,6 @@ public function handle(): void {
 			// In case of external storage and session credentials, the expiration
 			// fails because the command does not have those credentials
 
-			/** @var LoggerInterface $logger */
 			$logger = \OC::$server->get(LoggerInterface::class);
 			$logger->warning($e->getMessage(), [
 				'exception' => $e,