Fix viewer styling to adjust to upstream viewer changes #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
/backport to stable24 |
|
Filed nextcloud/viewer#1252 to discuss potential better options to let this styling be handled by the viewer itself. |
vinicius73
reviewed
May 17, 2022
| @@ -337,6 +337,11 @@ export default { | |||
| flex-direction: column; | |||
| background-color: var(--color-main-background); | |||
| transition: opacity .25s; | |||
|
|
|||
| .viewer & { | |||
There was a problem hiding this comment.
@vinicius73 It does not works without it 😁 because #richdocuments-wrapper is not a parent of .viewer in the DOM.
This rule applies to #richdocuments-wrapper if found inside .viewer.
julien-nc
approved these changes
May 17, 2022
| @@ -337,6 +337,11 @@ export default { | |||
| flex-direction: column; | |||
| background-color: var(--color-main-background); | |||
| transition: opacity .25s; | |||
|
|
|||
| .viewer & { | |||
There was a problem hiding this comment.
@vinicius73 It does not works without it 😁 because #richdocuments-wrapper is not a parent of .viewer in the DOM.
This rule applies to #richdocuments-wrapper if found inside .viewer.
|
/backport to stable24 |
|
The backport to stable24 failed. Please do this backport manually. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2190
While not nice, since the viewer added a
position: relative;on the parent, this is currently the only way that we can overlay the viewer header and make the richdocuments frame full screen.