Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make email optional #301

Closed
wants to merge 2 commits into from
Closed

Make email optional #301

wants to merge 2 commits into from

Conversation

skaramicke
Copy link
Contributor

In the Operation Tulip implementation of Nextcloud, absolute user integrity is key. Therefore we require a way for users to register without supplying any identifiable information. Although they could absolutely go register an anonymous email account somewhere, or just make up a fake email address if verification is turned off, we see the need to make this both intuitive and easy to use for the users.

It would greatly help us maintain our implementation if this optional email field could be part of the main repository of the registration app.

Respectfully yours,
Mikael Grön
Coder at Operation Tulip

@nickvergessen
Copy link
Member

Sounds sane, I will have a look next week 👍

Signed-off-by: Mikael <skaramicke@gmail.com>
Signed-off-by: Mikael <skaramicke@gmail.com>
@TheOneWithTheBraid
Copy link

Fixes #273

@TheOneWithTheBraid
Copy link

My first impression of the implementation is quite good. Please merge this soonly! We are currently workarrounding by client side JS which is highly unreliable. I am glad to see someone got the time to write a proper implementation.

@TheOneWithTheBraid
Copy link

Is there any official opinion on this PR? I am definitely waiting for this to be merged.

@nickvergessen
Copy link
Member

I'm lacking time atm, but when it works we will take it once I had time to review it.

@skaramicke
Copy link
Contributor Author

I'm lacking time atm, but when it works we will take it once I had time to review it.

You mean it is not working? If there’s a problem, I’m not aware of it.

Please mention me if anything needs fixing in the code.

@TheOneWithTheBraid
Copy link

@nickvergessen In our large-scale setup, it's working perfectly. I really can't wait for it to be merged - it's such an important feature.

@nickvergessen
Copy link
Member

Merged via #364 and will come with the release that also brings compatibility for 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants