Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Run audit #557

Merged
merged 3 commits into from
Oct 11, 2022
Merged

[stable24] Run audit #557

merged 3 commits into from
Oct 11, 2022

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen
Run npm audit
bc8c427 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review dependencies Pull requests that update a dependency file labels Oct 10, 2022
@nickvergessen nickvergessen added this to the Nextcloud 24.0.7 milestone Oct 10, 2022
@nickvergessen nickvergessen self-assigned this Oct 10, 2022
@nickvergessen
Copy link
Member Author

/compile amend /

@nickvergessen @nextcloud-command
Recompile
5156554 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
PVince81
PVince81 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

need to disable CI for php 7.4 ? it says the app is not compatible

@nickvergessen
Copy link
Member Author

It shouldn't test against master but stable24

@nickvergessen
Adjust testing version
c75274c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit a471c8b into stable24 Oct 11, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/audit branch October 11, 2022 08:02
@skjnldsv skjnldsv mentioned this pull request Oct 27, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Nextcloud 24.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @PVince81