Make FileListener respect .nomedia #497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
commented
Nov 16, 2022
| public function testFileListener(string $ignoreFileName) : void { | ||
| $this->config->setAppValue('recognize', 'imagenet.enabled', 'true'); | ||
|
|
||
| $this->testFile = $this->userFolder->newFile('/alpine.jpg', file_get_contents(__DIR__.'/res/alpine.JPG')); |
There was a problem hiding this comment.
@juliushaertl Shouldn't this trigger the file event listener?
There was a problem hiding this comment.
Yes, though one thing I'm unsure is if the test boostrap properly triggers the app loading in terms of that the Application register/boot methods are called. Maybe try to set an xdebug breakpoint or dd in the Application class when running the tests to see if that one actually gets registered.
There was a problem hiding this comment.
The problem was storage ID vs numeric storage ID 🙈
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
see #510 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
d833ffb to
199bfb4
Compare
|
nc master failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.