Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to @vladmandic/human #1237

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Switch to @vladmandic/human #1237

wants to merge 20 commits into from

Conversation

QuentinLemCode
Copy link

@QuentinLemCode QuentinLemCode commented Jan 23, 2025 •
edited
Loading

This PR take the work from @ghisch and try to make it production ready

#1218

@QuentinLemCode QuentinLemCode changed the title Switch human Switch to @vladmandic/human Jan 23, 2025
@QuentinLemCode QuentinLemCode marked this pull request as draft January 23, 2025 22:41
@Felitendo
Copy link

Nothing productive to add, just a thank you that this is finallly being worked on <3

@marcelklehr marcelklehr marked this pull request as ready for review January 24, 2025 14:18
@marcelklehr
Copy link
Member

Mmh, not sure why we don't have CI here

@bonswouar
Copy link
Collaborator

I'm really not sure why, but I had the option to click on "Approve and run" [the CI] so I just did and it worked 😅

@marcelklehr
Copy link
Member

@bonswouar You are a collaborator because you contributed previously ;)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@QuentinLemCode
Copy link
Author

I have to update my branch with the latest change
Also I haven't achieved to launch PHPUnit tests locally

ghisch and others added 17 commits February 9, 2025 23:02
@ghisch @QuentinLemCode
Switch to @vladmandic/human
f549104 
Signed-off-by: ghisch <168481965+ghisch@users.noreply.github.com>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@ghisch @QuentinLemCode
Update Dimensions
32e0327 
Adapt dimensions to 1024 as outputed by @vladmandic/human

Signed-off-by: ghisch <168481965+ghisch@users.noreply.github.com>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@ghisch @QuentinLemCode
Add @vladmandic/human to package.json
d64cf98 
Signed-off-by: ghisch <168481965+ghisch@users.noreply.github.com>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@ghisch @QuentinLemCode
Update package-lock.json
f61c32a 
Signed-off-by: ghisch <168481965+ghisch@users.noreply.github.com>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@QuentinLemCode
Fix ESLint
c7a0e4e 
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@QuentinLemCode
composer lock file
89c8c58 
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@QuentinLemCode
Apply php-cs-fixer
04e92c3 
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@marcelklehr @QuentinLemCode
fix: run cs:fix
0555f23 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@marcelklehr @QuentinLemCode
fix: Fix psalm errors
4625017 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@marcelklehr @QuentinLemCode
fix(cluster-faces-test): Update IMDB-Face share link
8eae229 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@marcelklehr @QuentinLemCode
Update php-scoper
7f182a3 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

# Conflicts:
#	vendor-bin/php-scoper/composer.lock
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@marcelklehr @QuentinLemCode
fix: Patch php-scoper to support php 8.4
6f31da1 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@marcelklehr @QuentinLemCode
fix: Fix psalm workflow
824c44f 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@marcelklehr @QuentinLemCode
fix: Fix psalm workflow
9f9f309 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@nickvergessen @QuentinLemCode
feat(deps): Add Nextcloud 32 support
68b9bda 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@nextcloud-bot @QuentinLemCode
Fix(l10n): Update translations from Transifex
5e48935 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@nextcloud-bot @QuentinLemCode
Fix(l10n): Update translations from Transifex
79a7c73 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
nextcloud-bot and others added 2 commits February 9, 2025 23:02
@nextcloud-bot @QuentinLemCode
Fix(l10n): Update translations from Transifex
c2a8f85 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
@QuentinLemCode
remove composer lockfile
d2fe5a9 
Signed-off-by: QuentinLemCode <quentinlemcode@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@QuentinLemCode @Felitendo @marcelklehr @bonswouar @ghisch @nickvergessen @nextcloud-bot