use new batch preview generation #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fallback to old method can be removed, since the app now is NC20 compatible only: 03665bc#diff-ab97a56738913a50d2334c4d3f10991748d3e29d011f5a674734b63d33d5ce9eR27 |
rullzer
approved these changes
Dec 21, 2020
rullzer
requested changes
Dec 21, 2020
1cb8d0d to
637931e
Compare
|
done |
637931e to
3d10307
Compare
Glandos
reviewed
Nov 5, 2022
Comment on lines
+203
to
+213
| $specifications = array_merge( | ||
| array_map(function ($squareSize) { | ||
| return ['width' => $squareSize, 'height' => $squareSize, 'crop' => true]; | ||
| }, $this->sizes['square']), | ||
| array_map(function ($heightSize) { | ||
| return ['width' => -1, 'height' => $heightSize, 'crop' => false]; | ||
| }, $this->sizes['height']), | ||
| array_map(function ($widthSize) { | ||
| return ['width' => $widthSize, 'height' => -1, 'crop' => false]; | ||
| }, $this->sizes['width']) | ||
| ); |
There was a problem hiding this comment.
I know this is very old, but $specifications doesn't depend on the current file, so it could be computed only once and set as class member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new optimized preview generation methods introduced with nextcloud/server#19495
I've used "feature detection" to remain backwards compatible (and to allow using the new methods if these get backported)