Fix fetching album content when navigating

[artonge]

When navigating between albums:

• The call to newFileMenuEntry was causing an error, because the entry were already existing as we did not remove it when destroying AlbumContent
• fetchAlbumContent was never called as the album's fileName did not change
• addFilesToAlbum was wrongly incrementing the items count, so I created another mutation called setAlbumFiles that only set the album's files.

[artonge]

/backport to stable25

[skjnldsv]

We should really prefer using Set for performances reasons :)
https://jsben.ch/JNnpx

[skjnldsv]

[artonge]

Can we address that later during a refactoring ?

[artonge]

But you made your point :)

[artonge]

I actually already made the change in collectionStoreFactory that I want to use for albums and share albums

photos/src/store/collectionStoreFactory.js

Lines 76 to 83 in fb218a1

	[`addFilesTo${capitalizedCollectionName}`](state, { collectionId, fileIdsToAdd }) {
	const collectionFiles = state[`${collectionName}sFiles`][collectionId] || []
	state[`${collectionName}sFiles`] = {
	...state[`${collectionName}sFiles`],
	[collectionId]: [...new Set([...collectionFiles, ...fileIdsToAdd])],
	}
	state[`${collectionName}s`][collectionId].nbItems += fileIdsToAdd.length
	},

[artonge]

But truth for truth, I am actually thinking of more generic store structure instead of having dedicated stores with collectionStoreFactory.

[artonge]

But first, make it work, then optimize

[skjnldsv]

Can we address that later during a refactoring ?

Absolutely 🎉

[skjnldsv]

I'm wondering if there isn't some tools out there that can detect such things 🤔
That seems not too crazy. Easy recommendations tbh 🙈

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

[artonge]

/backport to stable25