Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add albums feature and separate "folders" from "albums" #120

Closed
marcoambrosini opened this issue Jan 16, 2020 · 20 comments
Closed

Add albums feature and separate "folders" from "albums" #120

marcoambrosini opened this issue Jan 16, 2020 · 20 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request

Comments

@marcoambrosini
Copy link
Member

At the moment pictures need to physically be into the same folder to form a shareable collection. In my opinion, the current 'albums' navigation item should be called 'folders' as it provides a nicer way to browse photos in the folder structure, but aside from that It would be nice to be able to create any number of shareable collections of pictures (albums) without having to duplicate them in different folders.

This is how the menu would look like:

  • photos
  • folders
  • albums
  • shared albums
  • tagged photos
  • location
@Mikescops
Copy link
Member

It's a good idea (maybe Timeline instead of Photos) but this is related to #6 and #84 too.

@Mikescops Mikescops added 0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request labels Jan 17, 2020
@marcoambrosini

This comment has been minimized.

@kaffeeringe
Copy link

I miss the old handling of folders. It was everythiny but perfect, but at least I was able to navigate it.
Shotwell sorts all photos into folders of years, months and days. In Nextcloud it's now just 1 gazillion folders with numbers as names. And too many for previews to render...

@jancborchardt
Copy link
Member

It would be nice to be able to create any number of shareable collections of pictures (albums) without having to duplicate them in different folders.

Absolutely agree. It should be possible to select pictures and add them to "virtual" albums. We need to get a bit away from the filesystem paradigm here.

However, before we do this we should make sure we can integrate this with the mobile apps for feature parity, cc @tobiasKaminsky @marinofaggiana @AndyScherzinger.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Mar 21, 2020
@tobiasKaminsky
Copy link
Member

This needs some real deep thinking, adding a "virtual" structure on top of existing folder structure is a big challenge, both UX and tech-wise.

@skjnldsv
Copy link
Member

Yep :/
If we go for this, better drop the folder structure entirely and suggest marking all folder content as a single album instead. Also, we'd lose compatibility with other photos app I assume? Android is folderbased, no idea for iPhotos. But I ideally, opening your nextcloud data in iPhotos should also display your albums.

@kaffeeringe
Copy link

Please keep in mind that people already have hundreds of Photos in their Nextcloud.
The normal folders are not a replacement, because folders don't have a preview there. It's pretty hard to find certain photos within a complex folder structure.

@tobiasKaminsky
Copy link
Member

To not make this too complicated, I suggest to first find a good way within this photo app.
Then it should be somehow integrated into NC server, and then we can think about integration into clients.

For now I always understood the photo app as a different view onto photos in NC, with the same hierarchy of folders.
If this has now changed, it does not mean necessarily that there needs to be a change on server/clients.

@tobiasKaminsky
Copy link
Member

EDIT:
On Android we have the "photo" tab, which "only" lists images from new -> old.
If any, I guess we can try to do something there…

@marcoambrosini
Copy link
Member Author

both UX and tech-wise.

@tobiasKaminsky I don't think that it would be a challenge UX-wise as we already have many of examples of photo apps that do just that. It's common sense by now that creating an album in a photo app means selecting an arbitrary set of pictures from whatever location.

better drop the folder structure entirely and suggest marking all folder content as a single album instead.

@skjnldsv What do you mean with this?

Android is folderbased.

I think that as a benchmark here we should look at google photos, not at the standard android gallery app.

@skjnldsv
Copy link
Member

I think that as a benchmark here we should look at google photos, not at the standard android gallery app.

what about iOS photos? And macOS photos?

@marinofaggiana
Copy link
Member

Before this beautiful feature will be better write API for manage (and select) from server the photo. client-side API are inefficient.

@skjnldsv
Copy link
Member

API discussion in #205
@marinofaggiana we have an api for albums & shared albums already :)
For the timeline we're using the new (18) improved DAV search

@Spartachetto
Copy link

Spartachetto commented Jun 28, 2020

Maybe I am "late for the party", as this issue is not so new, yet from reading #6 and #84 I had thought that this app was a way to make possible an old feature request....

Have a look at nextcloud/gallery#116 , nextcloud/gallery#121 , nextcloud/gallery#463 . And also #335 .
All of them ask for a way of having the option of visualizing photos by tag. Or, even better, by metadata (tag/tags, GPS coordinates, EXIF, ...).

In addition consider that also the request of adding tags via the "visualization tool" (gallery or photos) is old: nextcloud/gallery#153 , nextcloud/gallery#204 . And also #226 . I have to say that the possibility of having a slideshow in the files app with the sidebar opened is something that probably fulfills this request.

Out of curiosity, have a look at who opened nextcloud/gallery#153 .... 😄

@wein-geist
Copy link

wein-geist commented Aug 9, 2020

The last few days/weeks I thought a lot about what to expect from a photos app, and the separation of folders and albums is also something I would appreciate.
I started a "discussion" over at the Nextcloud forum (no answers yet) of how to handle file structure and albums, amongst others. Maybe the ideas visualized in the drafts could be some inspiration here?

@knuxify
Copy link

knuxify commented Aug 19, 2020

imo we should leave folders as-is and make "albums" lists of files contained in a separate database (possibly related to the proposal in #84), with an option to generate an album from a folder, then separate the folder view and album view in the UI. That way we keep compatibility with old apps that use folders and add a new way to group albums for newer apps.

strugee added a commit that referenced this issue Sep 22, 2020
strugee added a commit that referenced this issue Sep 22, 2020
strugee added a commit that referenced this issue Sep 22, 2020
strugee added a commit that referenced this issue Sep 22, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
strugee added a commit that referenced this issue Sep 22, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
strugee added a commit that referenced this issue Sep 22, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
strugee added a commit that referenced this issue Sep 22, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
strugee added a commit that referenced this issue Sep 22, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
strugee added a commit that referenced this issue Sep 22, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
strugee added a commit that referenced this issue Oct 13, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
strugee added a commit that referenced this issue Oct 13, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
skjnldsv pushed a commit that referenced this issue Oct 14, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
skjnldsv pushed a commit that referenced this issue Oct 14, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
npmbuildbot-nextcloud bot pushed a commit that referenced this issue Oct 14, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@Mikescops
Copy link
Member

Fixed by #457

@strugee
Copy link
Member

strugee commented Oct 15, 2020

Reopening since the albums feature still needs to be added (#457 was just a rename).

@strugee strugee reopened this Oct 15, 2020
@Mikescops
Copy link
Member

It's a separate issue and described earlier #84, please leave this one closed.

@strugee
Copy link
Member

strugee commented Oct 16, 2020

Forgot about that one, thanks. Sorry for the spam!

skjnldsv pushed a commit that referenced this issue Nov 15, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
skjnldsv pushed a commit that referenced this issue Nov 15, 2020
Ref #120

Signed-off-by: AJ Jordan <alex@strugee.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request
Projects
None yet
Development

No branches or pull requests