Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable account after failed login attempts #102

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Disable account after failed login attempts #102

merged 1 commit into from
Apr 24, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 21, 2020

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added this to the Nextcloud 19 milestone Apr 23, 2020
@rullzer rullzer mentioned this pull request Apr 23, 2020
Merged
11 tasks
@rullzer rullzer force-pushed the enh/disable_failed branch from a5b11ed to 8d67b3b Compare April 23, 2020 18:57
@rullzer rullzer changed the title [PoC] Disable account after failed login attempts Disable account after failed login attempts Apr 23, 2020
@rullzer rullzer requested a review from kesselb April 23, 2020 18:59
blizzz
blizzz reviewed Apr 23, 2020
View reviewed changes
lib/AppInfo/Application.php Outdated Show resolved Hide resolved
@rullzer rullzer force-pushed the enh/disable_failed branch from 8d67b3b to bbddb1d Compare April 23, 2020 19:16
blizzz
blizzz approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick
🐘

lib/FailedLoginCompliance.php Outdated Show resolved Hide resolved
ChristophWurst
ChristophWurst approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

lib/FailedLoginCompliance.php Outdated Show resolved Hide resolved
@rullzer
Disable account after failed login attempts
d4250cf 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the enh/disable_failed branch from bbddb1d to d4250cf Compare April 24, 2020 14:34
@rullzer rullzer merged commit 2d1071c into master Apr 24, 2020
@rullzer rullzer deleted the enh/disable_failed branch April 24, 2020 14:47
@joshtrichards joshtrichards mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
5 participants
@rullzer @ChristophWurst @blizzz @juliusknorr @kesselb