Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support Android 10 System DayNight Modes #804

Closed
wbrawner opened this issue Dec 18, 2019 · 3 comments · Fixed by #812
Closed

[Feature Request] Support Android 10 System DayNight Modes #804

wbrawner opened this issue Dec 18, 2019 · 3 comments · Fixed by #812

Comments

@wbrawner
Copy link
Contributor

Much like the author of #723, I don't find the 10pm dark mode setting to be very useful, and would much rather the app simply follow the system settings as added in Android 10. Based on #660 and the themes.xml file it seems like the app is already using the DayNight theme, so it should be quite trivial to add an option for following the system settings. I'd be happy to contribute a pull request if needed, but I wanted to bring this up first before writing any code to make it happen.

@David-Development
Copy link
Member

This indeed sounds like a quite useful feature to me. If you already have an idea on how to implement this feature, feel free to create a pull request! And sorry for the delay!

@wbrawner
Copy link
Contributor Author

wbrawner commented Jan 2, 2020

No worries! I'm going to be offline the rest of this week but I can probably pick this up next week or next weekend and get a pull request opened.

@David-Development
Copy link
Member

Awesome, thank you so much!

wbrawner added a commit to wbrawner/news-android that referenced this issue Jan 9, 2020
Fixes nextcloud#804

Signed-off-by: William Brawner <me@wbrawner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants