Fix issue 1332 (photos from external folders not shown)

[umgfoin]

GeophotoService::getAll tries to load filecache-entries by id for each photo-entity in the photomapper.
Since NC30 this regularly fails for images located on ext. storage: As a result, the corresponding photos won't get included in the distributed photosCache and thus don't show up on the map.
I yet don't see the root-cause for the cache-failures here, but imho, access to the filecache is not needed - neither does it provide any performance gain. I decided to remove the corresponding filecache-code and retrieve the required attributes (Etag and mimetype) from the anyway fetched file-object.

$filesById = [];
$cache = $folder->getStorage()->getCache();
$previewEnableMimetypes = $this->getPreviewEnabledMimetypes();
foreach ($photoEntities as $photoEntity) {
        $cacheEntry = $cache->get($photoEntity->getFileId());
        if ($cacheEntry) {
                [...]
                $filesById[] = $file_object;
        }
        $this->photosCache->set($key, $filesById, 60 * 60 * 24);

This fixes #1332

Other changes:

• injection of LoggerInterface into GeophotoService.
  - A false failure-message when clearing the photo-cache was fixed.

[tacruc]

@umgfoin thanks for your contribution. Unfortunately my dev setup is currently not running. Did you notice any performance Impacts with this change?
Do you think we should create an option to enable and disable external storages? Or can this be done via .nomedia files anyway? What do you think?

[umgfoin]

Did you notice any performance Impacts with this change?

For me not noticeable: Loadtime for ~8K photos with empty photoCache till initial display: 15s
With warm photoCache 5s.
I think the changes have no performance impact at all: We're just using already present information instead of additionally querying the filecache for Etag and Mimetype:
$files = $folder->getById($photoEntity->getFileId()); is already fetching Etag and mimetype.

Do you think we should create an option to enable and disable external storages? Or can this be done via .nomedia files anyway?

The .nomedia exclusion-switch seems to be respected for external folders - I see no need for an explicit option.

[umgfoin]

@come-nc & @tacruc
I agree to discuss the clearcache-error in a separate PR.
What do you think of something like this:

public function clearCache(string $userId = ''): bool {
    try {  
                $this->photosCache->clear($userId);
                $this->timeOrderedPointSetsCache->clear($userId);
                $this->backgroundJobCache->clear('recentlyAdded:'.$userId);
                $this->backgroundJobCache->clear('recentlyUpdated:'.$userId);
                return true;
    } catch (\Exception $e) {
                return false;
    }
}

This would NOT treat clearing an empty cache as an error, but still give a visual GUI-feedback, if something abnormal happened.

[tacruc]

@umgfoin Let's go.