Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to directly view further attachments from email #5988

Open
1 of 3 tasks
Bibo-Joshi opened this issue Jan 27, 2022 · 12 comments
Open
1 of 3 tasks

Ability to directly view further attachments from email #5988

Bibo-Joshi opened this issue Jan 27, 2022 · 12 comments
Labels
1. to develop enhancement feature parity skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@Bibo-Joshi
Copy link

Bibo-Joshi commented Jan 27, 2022

Feature Request

#5701 was marked as closed by #5898, but IISC that only adds previews for images and not other files (e.g. pdfs). the preview is also only renders a small thumb at the bottom of the mail and one can't view the picture in full-screen without downloading it to PC/NC. (Please correctly me, if I got anything wrong here!)

From #2225 I understand that it's not straight forward to display arbitrary files, also because interaction with other NC components is necessary. However, from the discussion in #5701 and #5898 it's not clear to me whether or not previewing other file types is completely dropped or not.
If it's too complicated to get on any road map, feel free to close. If there is a chance that this could be implemented at some point, I would ask to keep this open :)

Summary

Ideally, I would like a preview to use the default tool assigned for the file type (if there is one), e.g. the markdown editor for .md files, pdf viewer for pdfs, OnlyOffice for .docx & friends, …

TBH, right now I'd already be happy if I could print PDF-attachments without having to download them to my PC/NC first :D

@jancborchardt
Copy link
Member

Agree on that – #5701 called for the ability to directly open it in a Viewer, and that is still valid.

@ChristophWurst
Copy link
Member

@jancborchardt please specify a list of MIME types that we have to support to remove another misunderstanding.

@jancborchardt jancborchardt changed the title Ability to directly view attachment from email Ability to directly view further attachments from email Feb 24, 2022
@jancborchardt
Copy link
Member

@ChristophWurst sorry, misunderstood that #5898 did do a viewer for images but is not deployed yet, which is already nice. :)

Then for further viewing it would be nice if Mail supports the same file types for viewing that the Files app also supports – not sure where that list is, but the essentials beyond images would probably indeed be the ones @Bibo-Joshi mentioned:

  • pdf
  • docx and other MS Office formats
  • odf and other LibreOffice formats
  • txt, md (that can be opened read-only in the Text app)

@jancborchardt
Copy link
Member

(Also, is there a specific reason we use a modal and not the same Viewer as in the Files app?)

@GretaD
Copy link
Contributor

GretaD commented Feb 24, 2022

(Also, is there a specific reason we use a modal and not the same Viewer as in the Files app?)

yes, attachments are saved in user folder which means that we cannot use viewer because viewer doesnt support that.

@jancborchardt
Copy link
Member

(Also, is there a specific reason we use a modal and not the same Viewer as in the Files app?)

yes, attachments are saved in user folder which means that we cannot use viewer because viewer doesnt support that.

Thanks for the explanation! Briefly talked with Christoph about that too, would of course be nice to make the Viewer compatible for this too, but I understand this is some work. cc @skjnldsv

@ChristophWurst
Copy link
Member

There is more discussion at #2225.

@no-response
Copy link

no-response bot commented Mar 17, 2022

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@no-response no-response bot closed this as completed Mar 17, 2022
Repository owner moved this from 🧭 Planning evaluation (dont pick) to ☑️ Done in 💌 📅 👥 Groupware team Mar 17, 2022
@Bibo-Joshi
Copy link
Author

Just double checking, because the responses were mixed: Is the auto-close desired b/c this feature is too complicated or is it a false-positive?

@no-response no-response bot removed the needs info label Mar 17, 2022
@no-response no-response bot reopened this Mar 17, 2022
Repository owner moved this from ☑️ Done to 📄 To do (5-20 entries) in 💌 📅 👥 Groupware team Mar 17, 2022
@danir-de
Copy link

It was closed because it wasn't active for long. See #5988 (comment)

This still is relevant and would be a great addition to the mail app, making it more functional.

@GretaD
Copy link
Contributor

GretaD commented Jun 20, 2022

Yes, its on our plan to work on this soon but no ETA yet

@ChristophWurst ChristophWurst added the skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills label Jul 16, 2022
@ChristophWurst
Copy link
Member

Primary goal of this ticket is to open PDF tickets. The others (Viewer) will come in the next step.

@ChristophWurst ChristophWurst moved this from 📄 To do (5-20 entries) to 🧭 Planning evaluation (dont pick) in 💌 📅 👥 Groupware team Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement feature parity skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
Status: 🧭 Planning evaluation
Development

No branches or pull requests

5 participants