Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to build the frontend using vite #673

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 7, 2024

Migrate to vite like most other apps are doing, this will decrease the JS asset size a lot.

@susnux susnux added enhancement New feature or request 3. to review labels Mar 7, 2024
@susnux susnux requested review from blizzz, artonge and come-nc March 7, 2024 14:09
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/modernize-ui branch from 1f93146 to c2738d6 Compare March 7, 2024 14:11
Copy link
Collaborator

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖖

@blizzz blizzz removed their request for review March 7, 2024 14:22
@come-nc come-nc merged commit 40c9115 into main Mar 7, 2024
27 checks passed
@come-nc come-nc deleted the feat/modernize-ui branch March 7, 2024 16:14
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants