Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace icon for shared folders #458

Closed
dartcafe opened this issue Jan 12, 2018 · 8 comments
Closed

Replace icon for shared folders #458

dartcafe opened this issue Jan 12, 2018 · 8 comments
Labels
Milestone

Comments

@dartcafe
Copy link

Expected behaviour

Web app and iOS app should use the same icon

Actual behaviour

Icon in iOS app
grafik
Icon in web app
grafik

Steps to reproduce

iOS version

11.2.5

App version

2.19.2

Server configuration

Nextcloud version: (see Nextcloud admin page)
13.0.0 beta4

@rakekniven
Copy link
Member

One icon show status "is shared to user" the other one "is shared by email".

@rakekniven
Copy link
Member

It is. Just checked it today with v12.0.4 while updating screenshot for Wikipedia.

bildschirmfoto 2018-01-13 um 17 45 21

@dartcafe
Copy link
Author

Sorry, but nope:
13.0.0 beta4
grafik

ios 2.19.2 Update (7)
grafik

@dartcafe dartcafe reopened this Jan 15, 2018
@rakekniven
Copy link
Member

Here it works.

iOS 2.19.2 (8)

2018-01-15 17-59-180232

Server v12.0.4

2018-01-15 18-00-030233

Anyone else can check? Weird.

@dartcafe
Copy link
Author

Ha. I think, I got it. The folder "shared" was shared with users AND via link. It seems, that the iOS app decides upon another order oth the sharing options, than the web app.
grafik

marinofaggiana pushed a commit that referenced this issue Jan 16, 2018
@marinofaggiana
Copy link
Member

Thanks @dartcafe good work !

@dartcafe
Copy link
Author

Thanks. Quick fixes. 👍

@rakekniven rakekniven added this to the V2.19.2 milestone Jan 17, 2018
@rakekniven
Copy link
Member

@dartcafe Had the same thought as you two comments above. Glad you found it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants