Update app to fit 18 new Sharing sidebar

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Use global eslint config and @nextcloud/packages

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Drone fix

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

.drone.yml

@@ -26,15 +26,15 @@ trigger:
     - pull_request
     - push
 ---
-
 kind: pipeline
-name: frontend
+name: webpack-build
+
 steps:
-  - name: jsbuild
-    image: nextcloudci/node:node-4
-    commands:
-      - apk add --no-cache make
-      - make
+- name: build
+  image: nextcloudci/node:node-4
+  commands:
+    - npm ci
+    - npm run build
 
 trigger:
   branch:

.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+	extends: [
+		'nextcloud'
+	]
+}

.stylelintrc.js

@@ -0,0 +1,32 @@
+module.exports = {
+	extends: 'stylelint-config-recommended-scss',
+	rules: {
+		indentation: 'tab',
+		'selector-type-no-unknown': null,
+		'number-leading-zero': null,
+		'rule-empty-line-before': [
+			'always',
+			{
+				ignore: ['after-comment', 'inside-block']
+			}
+		],
+		'declaration-empty-line-before': [
+			'never',
+			{
+				ignore: ['after-declaration']
+			}
+		],
+		'comment-empty-line-before': null,
+		'selector-type-case': null,
+		'selector-list-comma-newline-after': null,
+		'no-descending-specificity': null,
+		'string-quotes': 'single',
+		'selector-pseudo-element-no-unknown': [
+			true,
+			{
+				ignorePseudoElements: ['v-deep']
+			}
+		]
+	},
+	plugins: ['stylelint-scss']
+};

Makefile

@@ -37,6 +37,19 @@ clean:
 clean-dev:
 	rm -rf node_modules
 
+# Linting
+lint:
+	npm run lint
+
+lint-fix:
+	npm run lint:fix
+
+# Style linting
+stylelint:
+	npm run stylelint
+
+stylelint-fix:
+	npm run stylelint:fix
 
 appstore: clean package
 

lib/AppInfo/Application.php

@@ -86,7 +86,6 @@ private function setupGuestManagement() {
 				'OCA\Files::loadAdditionalScripts',
 				function () {
 					\OCP\Util::addScript('guests', 'main');
-					\OCP\Util::addStyle('guests', 'app');
 				}
 			);
 		}

lib/Controller/SettingsController.php

@@ -26,7 +26,6 @@
 use OCA\Guests\Config;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\DataResponse;
-use OCP\IConfig;
 use OCP\IRequest;
 use OCP\L10N\IFactory;
 

lib/GuestManager.php

@@ -176,6 +176,7 @@ public function getGuestInfo($userId) {
 		return [
 			'shares' => array_map(function (IShare $share) {
 				return [
+					'id' => $share->getId(),
 					'shared_by' => $share->getSharedBy(),
 					'mime_type' => $share->getNodeCacheEntry()->getMimeType(),
 					'name' => $share->getNodeCacheEntry()->getName(),

lib/RestrictionManager.php

@@ -101,8 +101,6 @@ public function setupRestrictions() {
 			/** @var NavigationManager $navManager */
 			$navManager = $this->server->getNavigationManager();
 
-			\OCP\Util::addStyle('guests', 'personal');
-
 			$this->server->registerService('NavigationManager', function () use ($navManager) {
 				return new FilteredNavigationManager($this->userSession->getUser(), $navManager, $this->whitelist);
 			});