Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check admin settings when fetching shared forms #2485

Merged
merged 3 commits into from
Jan 11, 2025
Merged

fix: Check admin settings when fetching shared forms #2485

merged 3 commits into from
Jan 11, 2025

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Jan 10, 2025 •
edited
Loading

  • Ensure the form settings can be set based on admin permissions
  • Ensure to only fetch public forms if enabled by admin

@susnux
fix(api): Make sure user has permissions to update access fields
2dbbee2 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.45%. Comparing base (2ea7409) to head (a467120).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2485      +/-   ##
============================================
- Coverage     43.51%   43.45%   -0.06%     
- Complexity      870      879       +9     
============================================
  Files            75       75              
  Lines          3330     3339       +9     
============================================
+ Hits           1449     1451       +2     
- Misses         1881     1888       +7

@susnux susnux force-pushed the fix/update-permissions branch 5 times, most recently from 84053ae to 67eb58b Compare January 10, 2025 14:16
@susnux susnux added bug Something isn't working 2. developing Work in progress labels Jan 10, 2025
@susnux susnux force-pushed the fix/update-permissions branch 11 times, most recently from e07aba9 to 8b73723 Compare January 10, 2025 16:24
susnux added 2 commits January 10, 2025 17:46
@susnux
fix(db): Only query public shared forms if enabled by admin
5ca6231 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test: Add test cases for admin settings possibly influencing the API
a467120 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/update-permissions branch from 802deb1 to a467120 Compare January 10, 2025 16:47
@susnux susnux changed the title Fix/update permissions fix: Check admin settings when fetching shared forms Jan 10, 2025
@susnux susnux marked this pull request as ready for review January 10, 2025 16:56
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 10, 2025
@susnux
Copy link
Collaborator Author

susnux commented Jan 10, 2025

/backport to stable4

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 10, 2025
@Chartman123 Chartman123 merged commit d713d48 into main Jan 11, 2025
54 checks passed
@Chartman123 Chartman123 deleted the fix/update-permissions branch January 11, 2025 12:04
@backportbot backportbot bot mentioned this pull request Jan 11, 2025
Merged
2 tasks
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jan 11, 2025
@Chartman123 Chartman123 added this to the 5.0 milestone Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chartman123 Chartman123 Chartman123 approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @Chartman123