Do not submit fields that not exists anymore

[Koc]

This pr aims to fix next bug. Here a reproducer:

1. Create form with 2 questions
2. Start filling the form but don't submit it
3. Edit form and remove 1st question

Expected result: form successfully submitted

Actual result: there is an error on BE side

[Chartman123]

Nice catch :)

However, with your changes the values for Dropdown, Date and Time questions aren't loaded anymore. Other than that some small comments/improvements to the code.

Instead of doing it when loading from LocalStorage we could also check it on submission and remove answers for invalid questions there. What do you think?

[susnux]

Maybe rather show a warning like: "Warning the form has changed since you last visit, do you want to restart?"
As also already filled questions might have changed the wording or similar. But also maybe something to track in an issue

[Koc]

@Chartman123 thanx for suggestion, I've changed approach

@susnux yeah, we can, but let's fix issue first. BTW what component can I use for raising this warning?

[Chartman123]

@Koc I'll have a look at it and test it this evening :)

[Chartman123]

Yes, works much better now. Just one small question :)

[Chartman123]

what component can I use for raising this warning?

You should use NcDialog like the two existing ones in Submit.vue :)

Clicked wrong button

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)