-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated NcMultiselect with recommended NcSelect #1471
Conversation
@susnux Looks good, but the styling does not fully fit the other components (border color and probably also the text color). I think that this should be fixed in the vue-lib. |
@Chartman123 Do you emptied your cache? Exactly the opposite should be the case. So it should now look like this: But there are two differences:
|
6fceff7
to
39b9e8e
Compare
Or maybe are you using NC 25.0.2? As the border was changed with this commit: nextcloud/server@20da75f on master (I am testing with current server master) which was backported to 25.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how it looked for me yesterday at first. I then ran another @susnux i will check the version later... |
This reminds me of nextcloud/text#3369 EDIT: 🥳 I finally found the origin of this issue, the theming variables are not set on the HTML tag but on the body tag. Fix: nextcloud/server#36462 |
39b9e8e
to
7476a03
Compare
@susnux: So should we merge this before the server fix? |
There is some discussion whether this is a server bug or should be fixed in the apps / libs. So I will file a PR against |
@susnux The border color is now correct, but the text color still differs... |
@susnux with the latest update of nc-vue the placeholder text is no longer shown |
A regression if the select is configured to be not searchable: nextcloud-libraries/nextcloud-vue#3833 |
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Rebased onto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@susnux the text color is still different to the other fields, but I think that we can merge this now :)
@susnux the text color is still different to the other fields, but I think that we can merge this now :) |
NcMultiselect
is deprecated the recommended alternative isNcSelect
(mostly a drop-in replacement but few properties and slots changed or removed).