[stable30] fix(flow_notifications): Improve app loading by checking if notificat… #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cb0873 to
09a8573
Compare
blizzz
approved these changes
Nov 11, 2024
…ions app is not installed and enabled when registering the app Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
09a8573 to
78d9732
Compare
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/230/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 78d97320
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/230/stable29Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
| ) { | ||
| } | ||
|
|
||
| public function handle(Event $event): void { | ||
| if (!$event instanceof RegisterOperationsEvent) { | ||
| return; | ||
| } elseif (!$this->appManager->isEnabledForUser('notifications')) { | ||
| $this->logger->error('Failed to register `flow_notifications` app. This could happen due to the `notifications` app isn\'t installed or enabled.', ['app' => 'flow_notifications']); |
There was a problem hiding this comment.
$this->logger->error('Failed to register `flow_notifications` app. This could happen due to the `notifications` app not being installed or enabled.', ['app' => 'flow_notifications']);
🙈
There was a problem hiding this comment.
@falghamdi125 he has a point there ^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #227
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.