Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(i18n): Fixed typo #1177

Merged
merged 2 commits into from
Apr 18, 2024
Merged

[stable29] fix(i18n): Fixed typo #1177

merged 2 commits into from
Apr 18, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 18, 2024

Backport of #1176

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Reported at Transifex.

Should be merged for v29.0.1

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

[skip ci]
@backportbot backportbot bot requested review from Pytal, susnux and rakekniven April 18, 2024 16:56
@backportbot backportbot bot added this to the Nextcloud 29 milestone Apr 18, 2024
@Pytal
Copy link
Member

Pytal commented Apr 18, 2024

/compile /

@Pytal Pytal marked this pull request as ready for review April 18, 2024 16:57
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Altahrim Altahrim mentioned this pull request Apr 18, 2024
9 tasks
@Altahrim Altahrim merged commit ab10a49 into stable29 Apr 18, 2024
39 of 40 checks passed
@Altahrim Altahrim deleted the backport/1176/stable29 branch April 18, 2024 19:03
@rakekniven
Copy link
Member

@Altahrim Why merging into stable29?
We have string freeze for nc29!
Now strings will become untranslated at Transifex.

@Altahrim
Copy link

Sorry, it's a mistake.
I am not familiar with our translation system…

@nickvergessen
Copy link
Member

Translations are already dropped from Transifex because the string was new:
3a3f397

So reverting the PR won't help.

Should we simply copy the translated strings into transifex, assuming they covered the typo good 🙈
Or is it better to keep the string empty?

@rakekniven
Copy link
Member

Or is it better to keep the string empty?

I would go this way.

First solution is a lot of manual work, or?

@nickvergessen
Copy link
Member

nickvergessen commented Apr 19, 2024

it seems to be only 26 files so 13 languages, I can do it quickly.
Would just be a problem if the other language translated the word our instead of the meaning of the full sentence.

@nickvergessen
Copy link
Member

I copy pasted the strings into deepl and all seem to translate to what was intended. So I would do that and mark the strings as not-reviewed

@nickvergessen
Copy link
Member

Done, added a comment on each language that was affected and triggered a manual sync:
e59520a

@rakekniven
Copy link
Member

Perfect.

@Altahrim
Copy link

Thank you both!

@nickvergessen
Copy link
Member

PS @rakekniven how did you notice? did you check the changelogs or some programmatical way that we could deploy during freezes?

@susnux
Copy link
Contributor

susnux commented Apr 19, 2024

@nickvergessen assigned by backport bot I would guess?

@nickvergessen
Copy link
Member

well backport bot, +/- of a t(, n(, $t(, $n(, ->t(, ->n(, … but even then it could be a legit change that does not cause a drop everytime.

@rakekniven
Copy link
Member

PS @rakekniven how did you notice? did you check the changelogs or some programmatical way that we could deploy during freezes?

I filed an PR to master/main and got another notification about a related backport PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants