-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable29] fix(i18n): Fixed typo #1177
Conversation
Reported at Transifex. Should be merged for v29.0.1 Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com> [skip ci]
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Altahrim Why merging into stable29? |
Sorry, it's a mistake. |
Translations are already dropped from Transifex because the string was new: So reverting the PR won't help. Should we simply copy the translated strings into transifex, assuming they covered the typo good 🙈 |
I would go this way. First solution is a lot of manual work, or? |
it seems to be only 26 files so 13 languages, I can do it quickly. |
I copy pasted the strings into deepl and all seem to translate to what was intended. So I would do that and mark the strings as not-reviewed |
Done, added a comment on each language that was affected and triggered a manual sync: |
Perfect. |
Thank you both! |
PS @rakekniven how did you notice? did you check the changelogs or some programmatical way that we could deploy during freezes? |
@nickvergessen assigned by backport bot I would guess? |
well backport bot, +/- of a |
I filed an PR to master/main and got another notification about a related backport PR. |
Backport of #1176
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.