Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewing of PDF documents #124

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Fix viewing of PDF documents #124

merged 2 commits into from
Mar 18, 2019

Conversation

ChristophWurst
Copy link
Member

Fixes a regression of #106 that prevents documents from being viewed (clicking a file entry does nothing, error logged to console).

@hirschrobert @skjnldsv please review

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes it!

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member

rullzer commented Mar 18, 2019

And pushed a fix for public previews as well :S

@rullzer rullzer merged commit 8ed7474 into master Mar 18, 2019
@rullzer rullzer deleted the fix/loading branch March 18, 2019 11:32
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants