Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable31] Adjust saving annotations in public pages to changes in Nextcloud 31 #1150

Conversation

danxuliu
Copy link
Member

Backport of #1149

@nextcloud/sharing  was already an implicit dependency, but now it is
made explicit to use the functions it provides in the PDF viewer code.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
In Nextcloud 31 the "sharingToken" element that was used to know the
token of the share was removed and replaced with data provided by the
initial state API. However, rather than directly getting the value using
the initial state API, the token is now got using the @nextcloud/sharing
library, which is expected to handle any future change.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu
Copy link
Member Author

/compile /

@Altahrim Altahrim mentioned this pull request Feb 20, 2025
5 tasks
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine!

@AndyScherzinger AndyScherzinger merged commit 670317a into stable31 Feb 20, 2025
35 of 36 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/1149/stable31-adjust-saving-annotations-in-public-pages-to-changes-in-nextcloud-31 branch February 20, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants