chore(deps): Bump pdfjs-dist from 3.11.174 to 4.0.189 (reloaded) #1131
Conversation
Bumps [pdfjs-dist](https://github.com/mozilla/pdfjs-dist) from 3.11.174 to 4.0.189. - [Commits](https://github.com/mozilla/pdfjs-dist/commits) --- updated-dependencies: - dependency-name: pdfjs-dist dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 3.11.174 to 4.0.189 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
af3318f to
3f70c00
Compare
|
Hey @danxuliu I just did a fast smoke test and the viewer seems to work fine in general, however I had a small problem when I use a public share link and set it to editable and try to save the modified file: |
That is known / expected due to the changes to the public share pages in Nextcloud 31. It should™ be unrelated to the PDF.js update :-) and will be fixed in a different pull request (that will also need to be backported to |
All right. Approving then |
Updated version of #856
Besides the adjustments to templates/viewer.php, #856 required #1107 to properly initialise the application options. Without #1107 it seemed to work, but it actually created subtle issues due to the options not being set in PDF.js. For example, an easy way to check that was to open a PDF that contains a link; without #1107 clicking on the link opens the link in the same tab, with #1107 it opens the link in a new tab.